-
-
Notifications
You must be signed in to change notification settings - Fork 331
bug(Cascader): should display Empty after click Clearable button #5128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis PR fixes a bug in the Cascader component where clicking the clear button would not display "Empty". The fix involves updating the Sequence diagram for Cascader clear button interactionsequenceDiagram
actor User
participant Cascader
User->>Cascader: Click clear button
Cascader->>Cascader: SetDefaultValue()
Note right of Cascader: Set CurrentValueAsString to empty
Cascader->>Cascader: RefreshDisplayText()
Cascader-->>User: Display empty text
State diagram for Cascader value clearingstateDiagram-v2
[*] --> HasValue: Initial state with value
HasValue --> Empty: Click clear button
Empty --> HasValue: Select new value
Empty --> [*]
HasValue --> [*]
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please complete all relevant sections in the PR template, particularly regarding documentation updates, demo updates, and verification steps. This helps maintain project quality and smooth review process.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5128 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 634 634
Lines 28174 28174
Branches 4041 4040 -1
=========================================
Hits 28174 28174 ☔ View full report in Codecov by Sentry. |
should display Empty after click Clearable button
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5127
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Bug Fixes: