Skip to content

feat(Layout): update IsFixedTab style #4801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 8, 2024
Merged

feat(Layout): update IsFixedTab style #4801

merged 3 commits into from
Dec 8, 2024

Conversation

ArgoZhang
Copy link
Collaborator

@ArgoZhang ArgoZhang commented Dec 8, 2024

update IsFixedTab style

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号

Description

fixes #4800

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Update the IsFixedTab style to enhance layout handling by adjusting height calculations and removing redundant styles.

New Features:

  • Update the style of the IsFixedTab component to improve layout handling.

Enhancements:

  • Adjust the height calculations for tabs in the IsFixedTab component to account for header and footer heights.
  • Remove unnecessary height styling from the tabs-body-content class in the Tab component.

Copy link
Contributor

sourcery-ai bot commented Dec 8, 2024

Reviewer's Guide by Sourcery

This PR updates the layout styling for fixed tabs and modifies menu behavior. The main changes focus on improving the tab layout's height calculations and removing the scroll-into-view functionality from the side menu.

Class diagram for updated layout styling

classDiagram
    class Layout {
        +is-fixed-tab
    }
    class Tabs {
        +height: calc(var(--bb-layout-height) - var(--bb-layout-header-height) - var(--bb-layout-footer-height))
    }
    class TabsBody {
        +height: calc(100% - var(--bb-tabs-item-height))
        +overflow: auto
    }
    Layout --> Tabs
    Tabs --> TabsBody
    note for TabsBody "Updated height calculation and added overflow auto"
Loading

Class diagram for updated menu behavior

classDiagram
    class Menu {
        +IsVertical
        +SideMenu
        +TopMenu
    }
    class SideMenu {
        -IsScrollToView
    }
    Menu --> SideMenu
    Menu --> TopMenu
    note for SideMenu "Removed IsScrollToView functionality"
Loading

File-Level Changes

Change Details Files
Updated fixed tab layout styling to use height-based calculations
  • Removed sticky positioning of tab headers
  • Added height calculation based on layout height minus header and footer heights
  • Added scrollable behavior to tab body content
  • Removed fixed height: 100% from tabs body content
src/BootstrapBlazor/Components/Layout/Layout.razor.scss
src/BootstrapBlazor/Components/Tab/Tab.razor.scss
Removed scroll-into-view functionality from side menu
  • Removed IsScrollIntoView parameter from SideMenu component
src/BootstrapBlazor/Components/Menu/Menu.razor

Assessment against linked issues

Issue Objective Addressed Explanation
#4800 Update the IsFixedTab style in the Layout component

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the enhancement New feature or request label Dec 8, 2024
@bb-auto bb-auto bot added this to the v9.0.0 milestone Dec 8, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The removal of IsScrollIntoView parameter appears to be a breaking change that isn't documented in the PR description. Please clarify if this was intentional and update the risk assessment/documentation accordingly.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Dec 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f0302ee) to head (c40a1ed).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #4801   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          620       620           
  Lines        27415     27415           
  Branches      3922      3922           
=========================================
  Hits         27415     27415           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang ArgoZhang merged commit 4801b7b into main Dec 8, 2024
5 checks passed
@ArgoZhang ArgoZhang deleted the fix-layout branch December 8, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(Layout): update IsFixedTab style
1 participant