-
-
Notifications
You must be signed in to change notification settings - Fork 331
feat(Layout): update IsFixedTab style #4801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis PR updates the layout styling for fixed tabs and modifies menu behavior. The main changes focus on improving the tab layout's height calculations and removing the scroll-into-view functionality from the side menu. Class diagram for updated layout stylingclassDiagram
class Layout {
+is-fixed-tab
}
class Tabs {
+height: calc(var(--bb-layout-height) - var(--bb-layout-header-height) - var(--bb-layout-footer-height))
}
class TabsBody {
+height: calc(100% - var(--bb-tabs-item-height))
+overflow: auto
}
Layout --> Tabs
Tabs --> TabsBody
note for TabsBody "Updated height calculation and added overflow auto"
Class diagram for updated menu behaviorclassDiagram
class Menu {
+IsVertical
+SideMenu
+TopMenu
}
class SideMenu {
-IsScrollToView
}
Menu --> SideMenu
Menu --> TopMenu
note for SideMenu "Removed IsScrollToView functionality"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- The removal of
IsScrollIntoView
parameter appears to be a breaking change that isn't documented in the PR description. Please clarify if this was intentional and update the risk assessment/documentation accordingly.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4801 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 620 620
Lines 27415 27415
Branches 3922 3922
=========================================
Hits 27415 27415 ☔ View full report in Codecov by Sentry. |
update IsFixedTab style
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #4800
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Update the IsFixedTab style to enhance layout handling by adjusting height calculations and removing redundant styles.
New Features:
Enhancements: