Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close all tabs before quitting. #1221

Merged
merged 2 commits into from
Jun 24, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,18 @@ protected override async Task<ExitCode> InvokeInternal(ILogger logger)
token.WaitHandle.WaitOne();
}

driver.Quit(); // Firefox driver hangs if Quit is not issued.
// close all tabs before quit is a workaround for broken Selenium - GeckoDriver communication in Firefox
ilonatommy marked this conversation as resolved.
Show resolved Hide resolved
// https://github.com/dotnet/runtime/issues/101617
while (driver.WindowHandles.Count > 1)
ilonatommy marked this conversation as resolved.
Show resolved Hide resolved
{
driver.Navigate().GoToUrl("about:config");
driver.Navigate().GoToUrl("about:blank");
driver.Close(); //Close Tab
driver.SwitchTo().Window(driver.WindowHandles.Last());
}
driver.Navigate().GoToUrl("about:config");
driver.Navigate().GoToUrl("about:blank");
driver.Quit(); // Firefox driver hangs if Quit is not issued.
driverService.Dispose();
driver.Dispose();
}
Expand Down
Loading