Skip to content

Commit

Permalink
Close all tabs before quitting. (#1221)
Browse files Browse the repository at this point in the history
* Close all tabs before quitting.

* Add logging.
  • Loading branch information
ilonatommy authored Jun 24, 2024
1 parent 1cc7eaa commit 34c5a24
Showing 1 changed file with 13 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,19 @@ protected override async Task<ExitCode> InvokeInternal(ILogger logger)
token.WaitHandle.WaitOne();
}

driver.Quit(); // Firefox driver hangs if Quit is not issued.
// close all tabs before quit is a workaround for broken Selenium - GeckoDriver communication in Firefox
// https://github.com/dotnet/runtime/issues/101617
logger.LogInformation($"Closing {driver.WindowHandles.Count} browser tabs before setting the main tab to config page and quitting.");
while (driver.WindowHandles.Count > 1)
{
driver.Navigate().GoToUrl("about:config");
driver.Navigate().GoToUrl("about:blank");
driver.Close(); //Close Tab
driver.SwitchTo().Window(driver.WindowHandles.Last());
}
driver.Navigate().GoToUrl("about:config");
driver.Navigate().GoToUrl("about:blank");
driver.Quit(); // Firefox driver hangs if Quit is not issued.
driverService.Dispose();
driver.Dispose();
}
Expand Down

0 comments on commit 34c5a24

Please sign in to comment.