Remove array/object allocs during Alt+Numpad composition, improve performance #9954
+86
−91
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes unnecessary
byte[]
,char[]
andStringBuilder
alocations during post-input processing when the char is inputted via Alt+Numpad combination. This is not somewhat impactful allocation but it will allow for more optimizations in the future.Time spent is cut by 2/5 which is more impactful in this case.
GetCurrentOEMCPEncoding method chain call
Customer Impact
Improved performance, decreased allocations.
Regression
No.
Testing
Local build, text input.
Risk
Low.
Microsoft Reviewers: Open in CodeFlow