Skip to content

Removed declarative CAS permission attributes and comments #994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 19, 2019
Merged

Removed declarative CAS permission attributes and comments #994

merged 3 commits into from
Jun 19, 2019

Conversation

ojhad
Copy link
Contributor

@ojhad ojhad commented Jun 18, 2019 •
edited
Loading

Part of Issue #241
Another PR upcoming to complete the rest of the attribute removal

@ojhad ojhad requested review from rladuca and vatsan-madhavan June 18, 2019 05:52
@ghost ghost requested review from ryalanms and stevenbrix June 18, 2019 05:52
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Jun 18, 2019
@vatsan-madhavan
Copy link
Member

  • DirectWriteForwarder continues to have these declarative permissions intact.
  • MediaTrace.cs in PresentationCore still has SecurityCriticalAttribute etc. that's left behind.

vatsan-madhavan
vatsan-madhavan requested changes Jun 18, 2019
View reviewed changes
Copy link
Member

@vatsan-madhavan vatsan-madhavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind listing the types that are part of your candidate list for removal?

@vatsan-madhavan
Copy link
Member

Pesentationcore, System.Xaml look good.

@vatsan-madhavan
Copy link
Member

The changes look good. Definitely requires another round of changes to complete the work, but I see no reason to block merging this.

@ojhad
Copy link
Contributor Author

ojhad commented Jun 19, 2019

Would you mind listing the types that are part of your candidate list for removal?

Talked offline, adding list here for posterity
permtypelist.txt

@ojhad ojhad merged commit 8c7ab15 into master Jun 19, 2019
@vatsan-madhavan vatsan-madhavan deleted the user/ojhad/removingattributescas branch August 23, 2019 20:12
@ThomasGoulet73 ThomasGoulet73 mentioned this pull request Apr 2, 2022
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Apr 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vatsan-madhavan vatsan-madhavan vatsan-madhavan approved these changes

@rladuca rladuca Awaiting requested review from rladuca

@ryalanms ryalanms Awaiting requested review from ryalanms

@stevenbrix stevenbrix Awaiting requested review from stevenbrix

Assignees
No one assigned
Labels
PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ojhad @vatsan-madhavan