Remove AssemblyFilter dead code as APTCA is not supported #9863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
requested review from
dipeshmsft and
singhashish-wpf
dotnet-policy-service
bot
added
PR
h3xds1nz
force-pushed
the
remove-assemblyfilter-dead
branch
from
9ed6eb6 to
569bae0
Compare
|
Resolved merge conflicts 02 |
harshit7962
added
Status:Completed
and removed
Status:InProgress
Status:Proposed
labels
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
siagupta0202
approved these changes
Oct 24, 2024
|
@h3xds1nz Thank you for your contribution |
|
@siagupta0202 Thank you. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes
AssemblyFilterclass that is just a compiled dead code. APTCA is not supported on .NET Core the same way CAS and XBAP is not supported. This is onNetFXinitiated viaPresentationAppDomainManagerthat has a hook on newAppDomaincreation. The type has been rendered obsolete the same time app domains ceased to exist even if it was initiated.Customer Impact
Decreased size of assemblies, better code quality of codebase for developers.
Regression
No.
Testing
Local build.
Risk
I believe there is none, this code is unused on .NET Core.
Microsoft Reviewers: Open in CodeFlow