Remove IsPresentationFrameworkVersionLessThan4 property and associated dead code #9749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
requested review from
dipeshmsft and
singhashish-wpf
dotnet-policy-service
bot
added
PR
siagupta0202
reviewed
Oct 9, 2024
src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Windows/Shell/WindowChromeWorker.cs
Show resolved
Hide resolved
siagupta0202
approved these changes
Oct 9, 2024
|
@h3xds1nz Thank you for your contribution. |
|
@siagupta0202 Thanks for including it :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since those code blocks are never entered (in #8681 @lindexi made
IsPresentationFrameworkVersionLessThan4strictlyfalseas it was always the result from reflection call anyways), we're just wasting memory by having the code around (and a tiny bit of perf).Customer Impact
Decreased framework memory usage, decreased file size; cleaner codebase for developers.
Regression
No.
Testing
Local build but the diff is super easy to review.
Risk
There isn't any.
Microsoft Reviewers: Open in CodeFlow