Remove unused CAS resource strings and its translations from all libraries #9698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
requested review from
dipeshmsft and
singhashish-wpf
dotnet-policy-service
bot
added
PR
harshit7962
added
Status:InProgress
Status:Proposed
Included in test pass
and removed
Status:InProgress
labels
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
LGTM |
siagupta0202
approved these changes
Jan 24, 2025
|
@h3xds1nz Thank you so much for your contributions! |
|
@siagupta0202 Thank you for including them :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1668
Description
Remove unused and obsolete CAS resource strings + translations from
WindowsBase,PresentationFramework,PresentationCoreandSystem.Xaml. This was long overdue since CAS removal and the types fromSystem.Security.Permissionsbut never done. I've separated each one into separate commits.SecurityExceptionForSettingSandboxExternalToTrueis fromSecurityHelper.ThrowExceptionIfSettingTrueInPartialTrust, also a removed method part of CAS removal. This should cover the full issue description.Customer Impact
Decreased file size; cleaner resource strings for developers.
Regression
No.
Testing
Local build.
Risk
Low.
Microsoft Reviewers: Open in CodeFlow