-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Opt-out switch for DynamicResource optimization #9501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Windows/ResourceDictionary.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Windows/ResourceDictionary.cs
Outdated
Show resolved
Hide resolved
LGTM |
src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Windows/ResourceDictionary.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Windows/ResourceDictionary.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Windows/ResourceDictionary.cs
Outdated
Show resolved
Hide resolved
If we want to just ignore the exception, why don't we go with |
@miloush, there were a few reasons for that- first, where to add the try-catch block, the only place where it seemed plausible was ResourceReferenceExpression and the exception occurs on Invalidation method calls so catching the exception there would result in skipping invalidations. Moreover, handling XamlParseException may lead to swallowing other valid exceptions. |
src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Windows/ResourceDictionary.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Implements the opt-out switch for DynamicResource optimization implemented in ( #5610, #9393 )
Customer Impact
See here #5610 (comment)
Regression
N/A
Testing
Local Testing with sample apps
Risk
cc @miloush @batzen @h3xds1nz
Microsoft Reviewers: Open in CodeFlow