Skip to content

Opt-out switch for DynamicResource optimization #9501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 8, 2024
Merged

Conversation

dipeshmsft
Copy link
Member

@dipeshmsft dipeshmsft commented Aug 1, 2024

Description

Implements the opt-out switch for DynamicResource optimization implemented in ( #5610, #9393 )

Customer Impact

See here #5610 (comment)

Regression

N/A

Testing

Local Testing with sample apps

Risk

cc @miloush @batzen @h3xds1nz

Microsoft Reviewers: Open in CodeFlow

@dipeshmsft dipeshmsft requested review from a team as code owners August 1, 2024 12:53
@dotnet-policy-service dotnet-policy-service bot added the PR metadata: Label to tag PRs, to facilitate with triage label Aug 1, 2024
@h3xds1nz
Copy link
Member

h3xds1nz commented Aug 1, 2024

LGTM

@miloush
Copy link
Contributor

miloush commented Aug 1, 2024

If we want to just ignore the exception, why don't we go with try catch instead of a switch?

@dipeshmsft
Copy link
Member Author

@miloush, there were a few reasons for that- first, where to add the try-catch block, the only place where it seemed plausible was ResourceReferenceExpression and the exception occurs on Invalidation method calls so catching the exception there would result in skipping invalidations. Moreover, handling XamlParseException may lead to swallowing other valid exceptions.

Copy link
Contributor

@hiteshkrmsft hiteshkrmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dipeshmsft dipeshmsft merged commit 0e08212 into main Aug 8, 2024
8 checks passed
@dipeshmsft dipeshmsft deleted the dynamic-switch branch August 8, 2024 19:03
@github-actions github-actions bot locked and limited conversation to collaborators Sep 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants