[main] Update dependencies from dotnet/winforms #9264
Conversation
![dotnet-maestro[bot]](https://avatars.githubusercontent.com/in/16706?s=60&v=4){kind=small}
…40619.5 Microsoft.Dotnet.WinForms.ProjectTemplates , Microsoft.Private.Winforms , System.Drawing.Common From Version 9.0.0-preview.6.24318.4 -> To Version 9.0.0-preview.6.24319.5 Dependency coherency updates System.Reflection.MetadataLoadContext,System.Windows.Extensions,Microsoft.NETCore.Platforms,System.Resources.Extensions,System.Runtime.Serialization.Formatters,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,VS.Redist.Common.NetCore.SharedFramework.x64.9.0,Microsoft.Win32.Registry.AccessControl,Microsoft.Win32.SystemEvents,System.CodeDom,System.ComponentModel.Composition,System.Configuration.ConfigurationManager,System.Data.Odbc,System.Data.OleDb,System.Diagnostics.EventLog,System.Diagnostics.PerformanceCounter,System.DirectoryServices.AccountManagement,System.DirectoryServices.Protocols,System.DirectoryServices,System.IO.Packaging,System.IO.Ports,System.Management,System.Reflection.Context,System.Runtime.Caching,System.Security.Cryptography.Pkcs,System.Security.Cryptography.ProtectedData,System.Security.Cryptography.Xml,System.Security.Permissions,System.ServiceModel.Syndication,System.ServiceProcess.ServiceController,System.Speech,System.Text.Encoding.CodePages,System.Threading.AccessControl,System.ComponentModel.Composition.Registration From Version 9.0.0-preview.6.24318.5 -> To Version 9.0.0-preview.6.24319.3 (parent: Microsoft.Private.Winforms
dotnet-policy-service
bot
added
the
PR
![dotnet-policy-service[bot]](https://avatars.githubusercontent.com/in/285228?s=60&v=4){kind=small}
Notification for subscribed users from https://github.com/dotnet/winforms:@dotnet/dotnet-winforms-admin Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.
|
…40619.5 Microsoft.Dotnet.WinForms.ProjectTemplates , Microsoft.Private.Winforms , System.Drawing.Common From Version 9.0.0-preview.6.24318.4 -> To Version 9.0.0-preview.6.24319.5 Dependency coherency updates System.Reflection.MetadataLoadContext,System.Windows.Extensions,Microsoft.NETCore.Platforms,System.Resources.Extensions,System.Runtime.Serialization.Formatters,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,VS.Redist.Common.NetCore.SharedFramework.x64.9.0,Microsoft.Win32.Registry.AccessControl,Microsoft.Win32.SystemEvents,System.CodeDom,System.ComponentModel.Composition,System.Configuration.ConfigurationManager,System.Data.Odbc,System.Data.OleDb,System.Diagnostics.EventLog,System.Diagnostics.PerformanceCounter,System.DirectoryServices.AccountManagement,System.DirectoryServices.Protocols,System.DirectoryServices,System.IO.Packaging,System.IO.Ports,System.Management,System.Reflection.Context,System.Runtime.Caching,System.Security.Cryptography.Pkcs,System.Security.Cryptography.ProtectedData,System.Security.Cryptography.Xml,System.Security.Permissions,System.ServiceModel.Syndication,System.ServiceProcess.ServiceController,System.Speech,System.Text.Encoding.CodePages,System.Threading.AccessControl,System.ComponentModel.Composition.Registration From Version 9.0.0-preview.6.24318.5 -> To Version 9.0.0-preview.6.24319.3 (parent: Microsoft.Private.Winforms
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…31-4a11-af1f-862326597df0
|
@dipeshmsft By the way, please approve the PR. |
|
@MichalStrehovsky looks like that didn't help. No idea why this didn't fail in the other PR. |
|
The mismatch still persist. Are the CI machines at https://dev.azure.com/dnceng/internal/_git/dotnet-wpf-int synchronized with the CI machines used in the public CI? |
|
wpf-int uses: according to https://helix.dot.net |
My theory is that it was the last CI run before the CI machines were updated:
If the dotnet-wpf-int build machines get updated at the same cadence, we probably just need to trigger a new build. If they're not we're stuck until someone updates them. |
|
That's a good guess because the Eng Infra Rollout happened yesterday. Queued https://dev.azure.com/dnceng/internal/_build/results?buildId=2478108&view=results |
|
@MichalStrehovsky while we are waiting on that, is there a way to avoid that tight coupling between VS versions being used in wpf-int and wpf? We hit that issue in the VMR as well a few months ago. |
Disabling LTCG (link-time code generation) would probably solve that. It's a bit of a deoptimization, so one would have to measure if it's acceptable. It might. With LTCG, the object files/libraries don't have machine code, but whatever intermediate bytecode Visual C++ compiler uses. This bytecode is not stable and requires a matching compiler. |
|
I think we have disabled LTCG once and later enabled it, once the systems were up to date. |
|
Given that this breaks CI whenever VS and the MSVC compiler gets updated I would really want to question the value of that. Especially when it comes to servicing and/or tight schedules. I will file an issue. |
akoeplinger
dismissed stale reviews from dipeshmsft, ViktorHofer, and dotnet-policy-service[bot]
via
8a3723f
|
@dipeshmsft your review got dismissed. Can you please approve once more? Thanks |
|
Once the build completes, we can merge this PR and close the newer one right, as its changes are now included here ? |
dotnet-maestro
bot
deleted the
darc-main-0e30143d-9131-4a11-af1f-862326597df0
branch
This pull request updates the following dependencies
Coherency Updates
The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format
From https://github.com/dotnet/winforms
Microsoft Reviewers: Open in CodeFlow