[main] Update dependencies from dotnet/winforms #9260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dotnet-maestro[bot]](https://avatars.githubusercontent.com/in/16706?s=60&v=4){kind=small}
…40618.3 Microsoft.Dotnet.WinForms.ProjectTemplates , Microsoft.Private.Winforms , System.Drawing.Common From Version 9.0.0-preview.6.24317.4 -> To Version 9.0.0-preview.6.24318.3 Dependency coherency updates System.Reflection.MetadataLoadContext,System.Windows.Extensions,Microsoft.NETCore.Platforms,System.Resources.Extensions,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,VS.Redist.Common.NetCore.SharedFramework.x64.9.0,Microsoft.Win32.Registry.AccessControl,Microsoft.Win32.SystemEvents,System.CodeDom,System.ComponentModel.Composition,System.Configuration.ConfigurationManager,System.Data.Odbc,System.Data.OleDb,System.Diagnostics.EventLog,System.Diagnostics.PerformanceCounter,System.DirectoryServices.AccountManagement,System.DirectoryServices.Protocols,System.DirectoryServices,System.IO.Packaging,System.IO.Ports,System.Management,System.Reflection.Context,System.Runtime.Caching,System.Security.Cryptography.Pkcs,System.Security.Cryptography.ProtectedData,System.Security.Cryptography.Xml,System.Security.Permissions,System.ServiceModel.Syndication,System.ServiceProcess.ServiceController,System.Speech,System.Text.Encoding.CodePages,System.Threading.AccessControl,System.ComponentModel.Composition.Registration From Version 9.0.0-preview.6.24316.2 -> To Version 9.0.0-preview.6.24318.4 (parent: Microsoft.Private.Winforms
![dotnet-policy-service[bot]](https://avatars.githubusercontent.com/in/285228?s=60&v=4){kind=small}
dotnet-policy-service
bot
added
the
PR
Notification for subscribed users from https://github.com/dotnet/winforms:@dotnet/dotnet-winforms-admin Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.
|
…40618.4 Microsoft.Dotnet.WinForms.ProjectTemplates , Microsoft.Private.Winforms , System.Drawing.Common From Version 9.0.0-preview.6.24317.4 -> To Version 9.0.0-preview.6.24318.4 Dependency coherency updates System.Reflection.MetadataLoadContext,System.Windows.Extensions,Microsoft.NETCore.Platforms,System.Resources.Extensions,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,VS.Redist.Common.NetCore.SharedFramework.x64.9.0,Microsoft.Win32.Registry.AccessControl,Microsoft.Win32.SystemEvents,System.CodeDom,System.ComponentModel.Composition,System.Configuration.ConfigurationManager,System.Data.Odbc,System.Data.OleDb,System.Diagnostics.EventLog,System.Diagnostics.PerformanceCounter,System.DirectoryServices.AccountManagement,System.DirectoryServices.Protocols,System.DirectoryServices,System.IO.Packaging,System.IO.Ports,System.Management,System.Reflection.Context,System.Runtime.Caching,System.Security.Cryptography.Pkcs,System.Security.Cryptography.ProtectedData,System.Security.Cryptography.Xml,System.Security.Permissions,System.ServiceModel.Syndication,System.ServiceProcess.ServiceController,System.Speech,System.Text.Encoding.CodePages,System.Threading.AccessControl,System.ComponentModel.Composition.Registration From Version 9.0.0-preview.6.24316.2 -> To Version 9.0.0-preview.6.24318.5 (parent: Microsoft.Private.Winforms
dotnet-maestro
bot
dismissed
dotnet-policy-service[bot]’s stale review
via
c7b0c43
…40618.4 Microsoft.Dotnet.WinForms.ProjectTemplates , Microsoft.Private.Winforms , System.Drawing.Common From Version 9.0.0-preview.6.24317.4 -> To Version 9.0.0-preview.6.24318.4 Dependency coherency updates System.Reflection.MetadataLoadContext,System.Windows.Extensions,Microsoft.NETCore.Platforms,System.Resources.Extensions,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,VS.Redist.Common.NetCore.SharedFramework.x64.9.0,Microsoft.Win32.Registry.AccessControl,Microsoft.Win32.SystemEvents,System.CodeDom,System.ComponentModel.Composition,System.Configuration.ConfigurationManager,System.Data.Odbc,System.Data.OleDb,System.Diagnostics.EventLog,System.Diagnostics.PerformanceCounter,System.DirectoryServices.AccountManagement,System.DirectoryServices.Protocols,System.DirectoryServices,System.IO.Packaging,System.IO.Ports,System.Management,System.Reflection.Context,System.Runtime.Caching,System.Security.Cryptography.Pkcs,System.Security.Cryptography.ProtectedData,System.Security.Cryptography.Xml,System.Security.Permissions,System.ServiceModel.Syndication,System.ServiceProcess.ServiceController,System.Speech,System.Text.Encoding.CodePages,System.Threading.AccessControl,System.ComponentModel.Composition.Registration From Version 9.0.0-preview.6.24316.2 -> To Version 9.0.0-preview.6.24318.5 (parent: Microsoft.Private.Winforms
This reverts commit a9c9b7d.
anjali-wpf
previously approved these changes
Jun 19, 2024
|
|
@MichalStrehovsky attempted to fix it in a9c9b7d I wonder why the fix did not help (WinForms did sth similar: dotnet/winforms@cf00f74) What we have right now in the log: Perhaps this fix should be extended to all the mentioned dlls? FWIW I've tried to build it locally and failed and DirectWriteForwarder is a managed C++ and I don't know how to fix it. |
|
I submitted a fix. WPF's infra makes it impossible for RAR (ResolveAssemblyReference) to decide which assembly is right. Filed #9261 |
ViktorHofer
approved these changes
Jun 19, 2024
|
Major kudos to @ViktorHofer for cracking yet another tricky MSBuild related snafu with those magic properties! 🌟 Your expertise saved the day as always! |
rchauhan18
approved these changes
Jun 19, 2024
dotnet-maestro
bot
deleted the
darc-main-35238ce3-138f-4676-929c-c05f140ca2c6
branch
Thanks a lot, you have most likely saved us from a lot of pain (either a major delay or a revert) |
|
Thanks for the kind words @am11 and @adamsitnik. I left a few more details in the tracking issue and explained why wpf's PrivateAssets global setting is problematic. There's a reason why PackageReferences flow transitively by default. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the following dependencies
Coherency Updates
The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format
From https://github.com/dotnet/winforms
Microsoft Reviewers: Open in CodeFlow