Skip to content

Applying Win11 Styles to TabControl, Frame, Page #8579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2024
Merged

Applying Win11 Styles to TabControl, Frame, Page #8579

merged 1 commit into from
Jan 5, 2024

Conversation

harshit7962
Copy link
Member

@harshit7962 harshit7962 commented Dec 21, 2023 •
edited by ghost
Loading

Description

Adding Win11 Styles to the following controls:

  1. TabControl
  2. Page
  3. Frame

Testing

Build Pass.
Verified the visual appearance changes of controls in a sample application.

Microsoft Reviewers: Open in CodeFlow

@harshit7962 harshit7962 requested a review from a team as a code owner December 21, 2023 11:19
@ghost ghost assigned harshit7962 Dec 21, 2023
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Dec 21, 2023
@ghost ghost requested review from dipeshmsft and singhashish-wpf December 21, 2023 11:19
anjali-wpf
anjali-wpf suggested changes Dec 21, 2023
View reviewed changes
Copy link

@anjali-wpf anjali-wpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ghost ghost added the 📭 waiting-author-feedback To request more information from author. label Dec 21, 2023
@ghost ghost removed the 📭 waiting-author-feedback To request more information from author. label Dec 22, 2023
@tbibre
Copy link

tbibre commented Dec 22, 2023

Hi,
I haven't checked this commit in details, but last time I checked, WPF UI TabControl style was not respecting TabStripPlacement : lepoco/wpfui#214

@pchaurasia14
Copy link
Member

@tbibre - Sure thing. We'll check it out

@lindexi lindexi mentioned this pull request Dec 25, 2023
Open
@harshit7962
Copy link
Member Author

@tbibre - We have raised the issue here. Will keep updating leads there. Thanks for bringing this to our notice.

@harshit7962 harshit7962 merged commit 8c438a3 into dotnet:feature/win11theming/staging Jan 5, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lindexi lindexi lindexi left review comments

@anjali-wpf anjali-wpf anjali-wpf approved these changes

@dipeshmsft dipeshmsft dipeshmsft approved these changes

@singhashish-wpf singhashish-wpf Awaiting requested review from singhashish-wpf

Assignees

@harshit7962 harshit7962

Labels
PR metadata: Label to tag PRs, to facilitate with triage Win 11 Theming
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@harshit7962 @tbibre @pchaurasia14 @lindexi @anjali-wpf @dipeshmsft