Skip to content

Minor Performance Optimization by Reducing Calls to AppDomain.CurrentDomain.FriendlyName #8567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Minor Performance Optimization by Reducing Calls to AppDomain.CurrentDomain.FriendlyName #8567

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1bdace
Minor Optimize Performance by Reducing Calls to `AppDomain.CurrentDom…
lindexi Dec 18, 2023
1a9db9b
Using the special string type
lindexi Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/Microsoft.DotNet.Wpf/src/Shared/MS/Win32/HwndWrapper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,10 +95,11 @@ public HwndWrapper(
// Register will fail if the string gets over 255 in length.
// So limit each part to a reasonable amount.
string appName;
if(null != AppDomain.CurrentDomain.FriendlyName && 128 <= AppDomain.CurrentDomain.FriendlyName.Length)
appName = AppDomain.CurrentDomain.FriendlyName.Substring(0, 128);
string currentDomainFriendlyName = AppDomain.CurrentDomain.FriendlyName;
if (null != currentDomainFriendlyName && 128 <= currentDomainFriendlyName.Length)
appName = currentDomainFriendlyName[..128];
else
appName = AppDomain.CurrentDomain.FriendlyName;
appName = currentDomainFriendlyName;

string threadName;
if(null != Thread.CurrentThread.Name && 64 <= Thread.CurrentThread.Name.Length)
Expand Down