Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use project ChecksumAlgorithm in code-behind. #7556

Conversation

ThomasGoulet73
Copy link
Contributor

@ThomasGoulet73 ThomasGoulet73 commented Feb 21, 2023

Fixes #7348

Description

Use the project ChecksumAlgorithm to generate #pragma checksum in code-behind using the correct algorithm.

Customer Impact

Projects setting ChecksumAlgorithm will now generate #pragma checksum using the correct algorithm.

Regression

No.

Testing

I used the repro project in #7348 to check the generated code.

Risk

Low.

/cc @swenkeratmicrosoft @tmat

Microsoft Reviewers: Open in CodeFlow

@ThomasGoulet73 ThomasGoulet73 requested a review from a team as a code owner February 21, 2023 04:37
@ghost ghost assigned ThomasGoulet73 Feb 21, 2023
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Feb 21, 2023
@ghost ghost requested review from dipeshmsft and singhashish-wpf February 21, 2023 04:37
@ghost ghost added the Community Contribution A label for all community Contributions label Feb 21, 2023
@dipeshmsft dipeshmsft merged commit 3862454 into dotnet:main Mar 20, 2023
@ThomasGoulet73
Copy link
Contributor Author

Thank you @dipeshmsft

@ThomasGoulet73 ThomasGoulet73 deleted the use-project-checksumalgorithm-in-code-behind branch March 21, 2023 02:09
@dipeshmsft
Copy link
Member

Thanks @ThomasGoulet73 for quick turnaround on this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Community Contribution A label for all community Contributions PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XAML code always generates SHA1 checksums in binaries even when csproj file says SHA256
2 participants