Replace resource constants with properties in PresentationCore #7519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
ThomasGoulet73
changed the title
ThomasGoulet73
deleted the
replace-resource-constants-with-properties-presentationcore
branch
|
@ThomasGoulet73 , thanks for your contribution in this task. Looks like this was last of the assemblies that needed this change, please correct me if I am wrong. If yes, then we are good to close #1 right ? |
|
Thank you @dipeshmsft.
This PR was for the last assembly but I'm preparing a cleanup PR that will mainly remove this: wpf/eng/WpfArcadeSdk/tools/SystemResources.props Lines 20 to 31 in 1f15ae0 I will mark my next PR as closing #1 so no need to close it manually. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #1
Description
Replace the use of resource constants with properties in PresentationCore. This follows the standard of other .Net projects, like dotnet/runtime.
This PR modifies generated files but I updated MilCodeGen to reflect these changes and I validated my modification to MilCodeGen using this PR: #6135. Here's the commit that updates MilCodeGen: d1707f2.
Customer Impact
None.
Regression
No.
Testing
Local build + CI.
Risk
None.
Microsoft Reviewers: Open in CodeFlow