Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] Enable in-build signing and do some clean-up #7016

Merged
merged 5 commits into from
Sep 9, 2022

Conversation

mmitche
Copy link
Member

@mmitche mmitche commented Sep 7, 2022

  • Remove some unused variables
  • Enable in-build signing on release branches
Microsoft Reviewers: Open in CodeFlow

- Remove some unused variables
- Enable in-build signing on release branches
@mmitche mmitche requested a review from a team as a code owner September 7, 2022 14:58
@ghost ghost assigned mmitche Sep 7, 2022
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Sep 7, 2022
@ghost ghost requested review from dipeshmsft, singhashish-wpf and SamBent September 7, 2022 14:59
@mmitche mmitche changed the title Enable in-build signing and do some clean-up [release/7.0] Enable in-build signing and do some clean-up Sep 7, 2022
@mmitche mmitche requested a review from dreddy-work September 7, 2022 14:59
@mmitche
Copy link
Member Author

mmitche commented Sep 7, 2022

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@mmitche
Copy link
Member Author

mmitche commented Sep 7, 2022

This will need fixes from #7010

@singhashish-wpf
Copy link
Member

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@mmitche
Copy link
Member Author

mmitche commented Sep 8, 2022

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@mmitche
Copy link
Member Author

mmitche commented Sep 8, 2022

@singhashish-wpf Any idea on these errors?

@singhashish-wpf
Copy link
Member

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@singhashish-wpf
Copy link
Member

Removed DRT Running step from 7.0 to unblock this. The DRT step is failing coz of the pool updates and related things. Will check and add it later.

@singhashish-wpf singhashish-wpf merged commit 3ae98db into dotnet:release/7.0 Sep 9, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Oct 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants