Change most non-generic sorts to be generic #6285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
ghost
requested review from
Especially for the sorts based on int[], this avoids boxing potentially huge numbers of ints. Even for classes, it avoids unnecessary casting, and switching to a delegate avoids a top-level allocation for the comparer inside the current Array.Sort implementation.
stephentoub
force-pushed
the
genericsort
branch
from
0b4e9df to
f8fc373
Compare
dipeshmsft
approved these changes
Jul 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Especially for the sorts based on int[], this avoids boxing potentially huge numbers of ints. Even for classes, it avoids unnecessary casting and expensive Array.Get/SetValue calls, and switching to a delegate avoids a top-level allocation for the comparer inside the current Array.Sort implementation.
Customer Impact
Unnecessary allocation, interface dispatch, expensive Array.Get/SetValue calls, etc.
Regression
No
Testing
CI
Risk
Minimal