Replace resource constants with properties in WindowsBase #6060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
…ed by WindowsBase" This reverts commit 86ef9fc.
|
I changed shared files to use properties even in projects that do not use properties by adding properties manually to SR. I think this is better than my initial approach of using nameof because it makes it easier to remove workaround when changing other projects to use properties because the properties will conflict with the generated properties. I think that this PR is now ready to review. This PR should have a pretty low risk of breaking something. |
anjali-wpf
approved these changes
Mar 28, 2022
ThomasGoulet73
deleted the
replace-resource-constants-with-properties-windowsbase
branch
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #1
Depends on #6059
Description
Replace the use of resource constants with properties in WindowsBase. This follows the standard of other .Net projects, like dotnet/runtime.
There are a bunch of files that are shared with other projects. I temporarily changed the use of constants with using nameof of properties in WindowsBase in this commit: 86ef9fc.
Customer Impact
None.
Regression
No.
Testing
I tested a few resources and made sure that the generated code in the property getter is the same as the original code.
Risk
None.