Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing HeadingLevel and IsDialog automation properties #4751

Merged
merged 44 commits into from
Jul 15, 2021
Merged

Implementing HeadingLevel and IsDialog automation properties #4751

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
b98bb57
Felipe coworking session for new UIAutomation property investigation
ryalanms May 25, 2021
9a5eb0e
adding None as the default result
May 26, 2021
0174765
adding apicompat changes
May 26, 2021
1a5afaf
Coworking session with Felipe: adding OS checks for new automation pr…
ryalanms Jun 9, 2021
adc3050
Merge branch 'main' into new.automation.property
ryalanms Jun 9, 2021
0cf1bdc
Merge branch 'main' into new.automation.property
ryalanms Jun 16, 2021
03125c0
Fix reference assemblies
ryalanms Jun 16, 2021
edd1008
Changing HeadingLevel enum to be in the correct way
Jun 22, 2021
0bcb251
adding isdialog implementation
Jul 5, 2021
0e3ff1d
changing to isdialog from getisdialog
Jul 5, 2021
3a8be23
improving isdialog implementation
Jul 6, 2021
ac060ac
Update src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/A…
guimafelipe Jul 6, 2021
e49e2b0
Update src/Microsoft.DotNet.Wpf/src/UIAutomation/UIAutomationClient/S…
guimafelipe Jul 6, 2021
7393512
Update src/Microsoft.DotNet.Wpf/src/UIAutomation/UIAutomationTypes/Sy…
guimafelipe Jul 6, 2021
81a1df3
Update src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/A…
guimafelipe Jul 6, 2021
1ee85b4
Update src/Microsoft.DotNet.Wpf/src/UIAutomation/UIAutomationTypes/Sy…
guimafelipe Jul 6, 2021
cbbc720
Update src/Microsoft.DotNet.Wpf/src/Shared/System/Windows/InterOp/OSV…
guimafelipe Jul 6, 2021
3921923
adding headinglevel summary
Jul 6, 2021
ba44bdd
removing empty lines and adding description
Jul 6, 2021
118a26a
Update src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/A…
guimafelipe Jul 6, 2021
f092113
Update src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/A…
guimafelipe Jul 6, 2021
d223aa8
suggested changes
Jul 6, 2021
df19535
removing unecessary comment and adding rs5 for isDialog
Jul 6, 2021
df85bbd
changing enum constant
Jul 7, 2021
d01beaa
Adding window isdialogcore implementation
Jul 7, 2021
a3ee3c1
overriding headinglevelcore in peers
Jul 7, 2021
3944e81
editing override of isdialog
Jul 7, 2021
a2ad746
changing values of enum for heading level so it correctly show in acc…
Jul 8, 2021
fed5d29
changing IsDialogCore() to virtual
Jul 9, 2021
23cc6b6
adding prefix in automation properties
Jul 9, 2021
0afb956
changing location of automationheadinglevel.cs to fix api compat errors
Jul 9, 2021
764d246
updating presentationcore return types for heading level
Jul 9, 2021
ee46685
Revert "changing location of automationheadinglevel.cs to fix api com…
Jul 9, 2021
c203d9e
maintaining the values of the enum as this for further testing
Jul 9, 2021
9ebec44
Update src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Wind…
guimafelipe Jul 9, 2021
cdf3786
changing enums to start on 0 and fixing automaticalli added code
Jul 9, 2021
a4df4cd
first try to add enum mapping
Jul 10, 2021
0b283ac
removing unreachable code
Jul 12, 2021
1ae4a20
moving the headinglevel conversion to automarionpeer.cs
Jul 12, 2021
d29ff29
removing api compat error
Jul 14, 2021
7ef5140
moving headinglevel ids enum to only the places where it is necessary
Jul 14, 2021
f7f4ff4
reverting baseline files
Jul 15, 2021
1c09b7d
removing disclaimer
Jul 15, 2021
c113364
removing switches
Jul 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 4 additions & 21 deletions src/Microsoft.DotNet.Wpf/ApiCompat/Baselines/PresentationCore-ref.baseline.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,27 +1,14 @@
Compat issues with assembly PresentationCore:
CannotChangeAttribute : Attribute 'System.ComponentModel.DesignerSerializationVisibilityAttribute' on 'System.Windows.ContentElement.CommandBindings' changed from '[DesignerSerializationVisibilityAttribute(2)]' in the contract to '[DesignerSerializationVisibilityAttribute(DesignerSerializationVisibility.Content)]' in the implementation.
CannotChangeAttribute : Attribute 'System.ComponentModel.DesignerSerializationVisibilityAttribute' on 'System.Windows.ContentElement.InputBindings' changed from '[DesignerSerializationVisibilityAttribute(2)]' in the contract to '[DesignerSerializationVisibilityAttribute(DesignerSerializationVisibility.Content)]' in the implementation.
CannotChangeAttribute : Attribute 'System.AttributeUsageAttribute' on 'System.Windows.LocalizabilityAttribute' changed from '[AttributeUsageAttribute(412, AllowMultiple=false, Inherited=true)]' in the contract to '[AttributeUsageAttribute(AttributeTargets.Class | AttributeTargets.Enum | AttributeTargets.Field | AttributeTargets.Property | AttributeTargets.Struct, AllowMultiple=false, Inherited=true)]' in the implementation.
CannotChangeAttribute : Attribute 'System.ComponentModel.DesignerSerializationVisibilityAttribute' on 'System.Windows.UIElement.CommandBindings' changed from '[DesignerSerializationVisibilityAttribute(2)]' in the contract to '[DesignerSerializationVisibilityAttribute(DesignerSerializationVisibility.Content)]' in the implementation.
CannotChangeAttribute : Attribute 'System.ComponentModel.DesignerSerializationVisibilityAttribute' on 'System.Windows.UIElement.InputBindings' changed from '[DesignerSerializationVisibilityAttribute(2)]' in the contract to '[DesignerSerializationVisibilityAttribute(DesignerSerializationVisibility.Content)]' in the implementation.
CannotChangeAttribute : Attribute 'System.ComponentModel.DesignerSerializationVisibilityAttribute' on 'System.Windows.UIElement.PersistId' changed from '[DesignerSerializationVisibilityAttribute(0)]' in the contract to '[DesignerSerializationVisibilityAttribute(DesignerSerializationVisibility.Hidden)]' in the implementation.
CannotChangeAttribute : Attribute 'System.ComponentModel.DesignerSerializationVisibilityAttribute' on 'System.Windows.UIElement.RenderSize' changed from '[DesignerSerializationVisibilityAttribute(0)]' in the contract to '[DesignerSerializationVisibilityAttribute(DesignerSerializationVisibility.Hidden)]' in the implementation.
CannotChangeAttribute : Attribute 'System.ComponentModel.DesignerSerializationVisibilityAttribute' on 'System.Windows.UIElement3D.CommandBindings' changed from '[DesignerSerializationVisibilityAttribute(2)]' in the contract to '[DesignerSerializationVisibilityAttribute(DesignerSerializationVisibility.Content)]' in the implementation.
CannotChangeAttribute : Attribute 'System.ComponentModel.DesignerSerializationVisibilityAttribute' on 'System.Windows.UIElement3D.InputBindings' changed from '[DesignerSerializationVisibilityAttribute(2)]' in the contract to '[DesignerSerializationVisibilityAttribute(DesignerSerializationVisibility.Content)]' in the implementation.
MembersMustExist : Member 'public System.Windows.DependencyProperty System.Windows.DependencyProperty System.Windows.Automation.AutomationProperties.IsDialogProperty' does not exist in the implementation but it does exist in the contract.
MembersMustExist : Member 'public System.Boolean System.Windows.Automation.Peers.AutomationPeer.IsDialog()' does not exist in the implementation but it does exist in the contract.
MembersMustExist : Member 'protected System.Boolean System.Windows.Automation.Peers.AutomationPeer.IsDialogCore()' does not exist in the implementation but it does exist in the contract.
CannotChangeAttribute : Attribute 'System.ComponentModel.DesignerSerializationVisibilityAttribute' on 'System.Windows.Input.FocusManager.GetFocusedElement(System.Windows.DependencyObject)' changed from '[DesignerSerializationVisibilityAttribute(0)]' in the contract to '[DesignerSerializationVisibilityAttribute(DesignerSerializationVisibility.Hidden)]' in the implementation.
CannotChangeAttribute : Attribute 'System.ComponentModel.DesignerSerializationVisibilityAttribute' on 'System.Windows.Input.InputScope.Names' changed from '[DesignerSerializationVisibilityAttribute(2)]' in the contract to '[DesignerSerializationVisibilityAttribute(DesignerSerializationVisibility.Content)]' in the implementation.
CannotChangeAttribute : Attribute 'System.ComponentModel.DesignerSerializationVisibilityAttribute' on 'System.Windows.Input.InputScope.PhraseList' changed from '[DesignerSerializationVisibilityAttribute(2)]' in the contract to '[DesignerSerializationVisibilityAttribute(DesignerSerializationVisibility.Content)]' in the implementation.
MembersMustExist : Member 'internal System.Windows.Media.Composition.DUCE.ResourceHandle System.Windows.Media.Brush.AddRefOnChannelCore(System.Windows.Media.Composition.DUCE.Channel)' does not exist in the implementation but it does exist in the contract.
MembersMustExist : Member 'internal System.Windows.Media.Composition.DUCE.Channel System.Windows.Media.Brush.GetChannelCore(System.Int32)' does not exist in the implementation but it does exist in the contract.
MembersMustExist : Member 'internal System.Int32 System.Windows.Media.Brush.GetChannelCountCore()' does not exist in the implementation but it does exist in the contract.
MembersMustExist : Member 'internal System.Windows.Media.Composition.DUCE.ResourceHandle System.Windows.Media.Brush.GetHandleCore(System.Windows.Media.Composition.DUCE.Channel)' does not exist in the implementation but it does exist in the contract.
MembersMustExist : Member 'internal void System.Windows.Media.Brush.ReleaseOnChannelCore(System.Windows.Media.Composition.DUCE.Channel)' does not exist in the implementation but it does exist in the contract.
CannotChangeAttribute : Attribute 'System.ComponentModel.DesignerSerializationVisibilityAttribute' on 'System.Windows.Media.FamilyTypeface.DeviceFontCharacterMetrics' changed from '[DesignerSerializationVisibilityAttribute(2)]' in the contract to '[DesignerSerializationVisibilityAttribute(DesignerSerializationVisibility.Content)]' in the implementation.
CannotChangeAttribute : Attribute 'System.ComponentModel.DesignerSerializationVisibilityAttribute' on 'System.Windows.Media.FontFamily.FamilyMaps' changed from '[DesignerSerializationVisibilityAttribute(2)]' in the contract to '[DesignerSerializationVisibilityAttribute(DesignerSerializationVisibility.Content)]' in the implementation.
CannotChangeAttribute : Attribute 'System.ComponentModel.DesignerSerializationVisibilityAttribute' on 'System.Windows.Media.FontFamily.FamilyNames' changed from '[DesignerSerializationVisibilityAttribute(2)]' in the contract to '[DesignerSerializationVisibilityAttribute(DesignerSerializationVisibility.Content)]' in the implementation.
CannotChangeAttribute : Attribute 'System.ComponentModel.DesignerSerializationVisibilityAttribute' on 'System.Windows.Media.FontFamily.FamilyTypefaces' changed from '[DesignerSerializationVisibilityAttribute(2)]' in the contract to '[DesignerSerializationVisibilityAttribute(DesignerSerializationVisibility.Content)]' in the implementation.
CannotChangeAttribute : Attribute 'System.Windows.Markup.DesignerSerializationOptionsAttribute' on 'System.Windows.Media.FontFamilyMap.Target' changed from '[DesignerSerializationOptionsAttribute(1)]' in the contract to '[DesignerSerializationOptionsAttribute(DesignerSerializationOptions.SerializeAsAttribute)]' in the implementation.
CannotChangeAttribute : Attribute 'System.Windows.Markup.DesignerSerializationOptionsAttribute' on 'System.Windows.Media.FontFamilyMap.Unicode' changed from '[DesignerSerializationOptionsAttribute(1)]' in the contract to '[DesignerSerializationOptionsAttribute(DesignerSerializationOptions.SerializeAsAttribute)]' in the implementation.
MembersMustExist : Member 'internal System.Object System.Windows.Media.Converters.BaseIListConverter.ConvertFromCore(System.ComponentModel.ITypeDescriptorContext, System.Globalization.CultureInfo, System.String)' does not exist in the implementation but it does exist in the contract.
MembersMustExist : Member 'internal System.Object System.Windows.Media.Converters.BaseIListConverter.ConvertToCore(System.ComponentModel.ITypeDescriptorContext, System.Globalization.CultureInfo, System.Object, System.Type)' does not exist in the implementation but it does exist in the contract.
MembersMustExist : Member 'internal System.Windows.Media.Composition.DUCE.ResourceHandle System.Windows.Media.Effects.Effect.AddRefOnChannelCore(System.Windows.Media.Composition.DUCE.Channel)' does not exist in the implementation but it does exist in the contract.
Expand All @@ -32,10 +19,6 @@ MembersMustExist : Member 'internal System.Windows.Rect System.Windows.Media.Eff
MembersMustExist : Member 'internal void System.Windows.Media.Effects.Effect.ReleaseOnChannelCore(System.Windows.Media.Composition.DUCE.Channel)' does not exist in the implementation but it does exist in the contract.
MembersMustExist : Member 'internal void System.Windows.Media.Imaging.BitmapDecoder.SealObject()' does not exist in the implementation but it does exist in the contract.
MembersMustExist : Member 'internal void System.Windows.Media.Imaging.BitmapEncoder.SealObject()' does not exist in the implementation but it does exist in the contract.
CannotChangeAttribute : Attribute 'System.ComponentModel.DesignerSerializationVisibilityAttribute' on 'System.Windows.Media.Imaging.BitmapImage.StreamSource' changed from '[DesignerSerializationVisibilityAttribute(0)]' in the contract to '[DesignerSerializationVisibilityAttribute(DesignerSerializationVisibility.Hidden)]' in the implementation.
CannotChangeAttribute : Attribute 'System.ComponentModel.DesignerSerializationVisibilityAttribute' on 'System.Windows.Media.Media3D.ContainerUIElement3D.Children' changed from '[DesignerSerializationVisibilityAttribute(2)]' in the contract to '[DesignerSerializationVisibilityAttribute(DesignerSerializationVisibility.Content)]' in the implementation.
CannotChangeAttribute : Attribute 'System.ComponentModel.DesignerSerializationVisibilityAttribute' on 'System.Windows.Media.Media3D.ModelVisual3D.Children' changed from '[DesignerSerializationVisibilityAttribute(2)]' in the contract to '[DesignerSerializationVisibilityAttribute(DesignerSerializationVisibility.Content)]' in the implementation.
CannotChangeAttribute : Attribute 'System.ComponentModel.DesignerSerializationVisibilityAttribute' on 'System.Windows.Media.Media3D.Viewport3DVisual.Children' changed from '[DesignerSerializationVisibilityAttribute(2)]' in the contract to '[DesignerSerializationVisibilityAttribute(DesignerSerializationVisibility.Content)]' in the implementation.
MembersMustExist : Member 'internal System.Windows.Media.TextFormatting.TextParagraphCache System.Windows.Media.TextFormatting.TextFormatter.CreateParagraphCache(System.Windows.Media.TextFormatting.TextSource, System.Int32, System.Double, System.Windows.Media.TextFormatting.TextParagraphProperties, System.Windows.Media.TextFormatting.TextLineBreak, System.Windows.Media.TextFormatting.TextRunCache)' does not exist in the implementation but it does exist in the contract.
CannotChangeAttribute : Attribute 'System.AttributeUsageAttribute' on 'System.Windows.Resources.AssemblyAssociatedContentFileAttribute' changed from '[AttributeUsageAttribute(1, AllowMultiple=true)]' in the contract to '[AttributeUsageAttribute(AttributeTargets.Assembly, AllowMultiple=true)]' in the implementation.
Total Issues: 39
Total Issues: 22
Loading