Use params and char overload #4231
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses the single char overload instead of the one using char array.
Note: PresentationBuildTasks targets .Net Framework 4.7.2 and .Net Core 2.1. The method
string.Split(char)
was introduced in .Net Core 2.0 so the changes do not apply to .Net Framework. .Net Framework 4.7.2 will callstring.Split(params char[])
and .Net Core 2.1 will callstring.Split(char)
.Thoses changes should give a small perf gain and reduce memory usage.
Here is the result for the method
string.Split
on my machine:Customer Impact
Regression
Testing
Risk
There is a risk that the behavior for the method overload using char array is not the same as the one using a single char but since those method are in the BCL, I think the risk is very low.