Add the property for MicrosoftWindowsDesktopSdkImported #3207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So SDK side of the change will not be blocked by WPF side of change More info in dotnet/sdk#12108
ghost
requested review from
|
@ryalanms this is a simple marker to avoid double import. Could you approve that? |
|
cc @dsplaisted |
ryalanms
approved these changes
Jul 2, 2020
|
Will you have a similar marker in Sdk.targets as well? |
|
This property is enough, we won't import both props and targets if it has the mark |
|
And please help me merge it. I don't have the merge access |
|
@vatsan-madhavan @ryalanms could you help me merge this change? |
|
@ryalanms should take point here. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So SDK side of the change will not be blocked by WPF side of change
More info in dotnet/sdk#12108