Skip to content

Fixing MAS Compliance Issues #1278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
3 commits merged into from
Jul 23, 2019
Merged

Fixing MAS Compliance Issues #1278

3 commits merged into from
Jul 23, 2019

Conversation

arpitmathur
Copy link
Contributor

@arpitmathur arpitmathur commented Jul 16, 2019 •
edited
Loading

Fixes #791, Fixes #1015

This pull request contains two changes.

  1. Setting ScrollPattern on ComboBox to only be enabled when its dropdown is opened.
  2. Ensuring that expander is added to GroupItemDataAutomationPeer if it is the only child. This ensures that the expander is accessible to screen readers.

@arpitmathur arpitmathur requested a review from a team July 16, 2019 01:34
@ghost ghost requested review from vatsan-madhavan, rladuca, ryalanms and stevenbrix and removed request for a team July 16, 2019 01:34
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Jul 16, 2019
@ghost ghost requested a review from SamBent July 16, 2019 01:34
@dnfclas
Copy link

dnfclas commented Jul 16, 2019 •
edited
Loading

CLA assistant check
All CLA requirements met.

vatsan-madhavan
vatsan-madhavan reviewed Jul 16, 2019
View reviewed changes
Copy link
Member

@vatsan-madhavan vatsan-madhavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; @rladuca, @SamBent - would you please take a look as well?

@arpitmathur - I'm assuming that the individual samples against which these bugs were found now function correctly. Have these samples been added to microsoft/wpf-samples repo?

@arpitmathur arpitmathur force-pushed the dev/armathur/accessibilityfixes branch from 64f31f1 to c14f7d4 Compare July 23, 2019 22:22
@rladuca
Copy link
Member

rladuca commented Jul 23, 2019

Branch is all fixed up now, going to sign off.

@rladuca rladuca added the auto_merge bot-command label Jul 23, 2019
@ghost
Copy link

ghost commented Jul 23, 2019

Hello @rladuca!

Because this pull request has the auto_merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@rladuca
Copy link
Member

rladuca commented Jul 23, 2019

@msftbot require 1 sign off before merging

@ghost
Copy link

ghost commented Jul 23, 2019

Hello @rladuca!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I'll only merge this pull request if it has at least 1 approval

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@rladuca
Copy link
Member

rladuca commented Jul 23, 2019

@msftbot wait 5 minutes before merging

@ghost
Copy link

ghost commented Jul 23, 2019

Hello @rladuca!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I'll only merge this pull request if it has at least 1 approval
  • I won't merge this pull request until after the UTC date Tue, 23 Jul 2019 22:33:31 GMT, which is in 5 minutes

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@ghost ghost merged commit 8b20a88 into master Jul 23, 2019
@ghost ghost deleted the dev/armathur/accessibilityfixes branch July 23, 2019 22:38
@arpitmathur arpitmathur mentioned this pull request Jul 23, 2019
Closed
@grubioe grubioe mentioned this pull request Jul 29, 2019
Closed
@kronic kronic mentioned this pull request May 24, 2021
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Apr 16, 2022
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vatsan-madhavan vatsan-madhavan vatsan-madhavan left review comments

@miguep miguep miguep left review comments

@rladuca rladuca rladuca approved these changes

@ryalanms ryalanms Awaiting requested review from ryalanms

@stevenbrix stevenbrix Awaiting requested review from stevenbrix

@SamBent SamBent Awaiting requested review from SamBent

Assignees
No one assigned
Labels
auto_merge bot-command PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expander control is not narrated Accessibility: (combobox control) An element of the given type should not support the Scroll pattern.
5 participants
@arpitmathur @dnfclas @rladuca @vatsan-madhavan @miguep