Remove Verify classes, use standard BCL throw helpers instead #10882
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes
Verify
classes which are mostly just dead-code besides null-checks which can be serviced by the standardArgumentNullException.ThrowIfNull
helper. TheWindowsBase
calls were then used in 2 places only in JumpLists, so I've inlined those and moved the relevant resources up toPresentationFramework
(note thatPresentationCore
didn't have any translations).This will also improve codegen overall and allows to remove the currently globally suppressed
CA1062
.Customer Impact
Cleaner codebase for developers, smaller assembly size.
Regression
No.
Testing
Local build.
Risk
Low, just 1:1 replacements basically.
Microsoft Reviewers: Open in CodeFlow