Skip to content

Remove Verify classes, use standard BCL throw helpers instead #10882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

h3xds1nz
Copy link
Member

@h3xds1nz h3xds1nz commented May 26, 2025

Description

Removes Verify classes which are mostly just dead-code besides null-checks which can be serviced by the standard ArgumentNullException.ThrowIfNull helper. The WindowsBase calls were then used in 2 places only in JumpLists, so I've inlined those and moved the relevant resources up to PresentationFramework (note that PresentationCore didn't have any translations).

This will also improve codegen overall and allows to remove the currently globally suppressed CA1062.

Customer Impact

Cleaner codebase for developers, smaller assembly size.

Regression

No.

Testing

Local build.

Risk

Low, just 1:1 replacements basically.

Microsoft Reviewers: Open in CodeFlow

@h3xds1nz h3xds1nz requested a review from a team as a code owner May 26, 2025 12:04
@dotnet-policy-service dotnet-policy-service bot added PR metadata: Label to tag PRs, to facilitate with triage Community Contribution A label for all community Contributions labels May 26, 2025
Copy link

codecov bot commented May 26, 2025

Codecov Report

Attention: Patch coverage is 0% with 34 lines in your changes missing coverage. Please review.

Project coverage is 2.98912%. Comparing base (57fe8ac) to head (0be8f8b).
Report is 10 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main     #10882          +/-   ##
===================================================
- Coverage   13.48885%   2.98912%   -10.49973%     
===================================================
  Files           3317       3317                  
  Lines         664749     664677          -72     
  Branches       74643      74639           -4     
===================================================
- Hits           89667      19868       -69799     
- Misses        572488     644628       +72140     
+ Partials        2594        181        -2413     
Flag Coverage Δ
Debug 2.98912% <0.00000%> (-10.49973%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution A label for all community Contributions PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant