Use StrongBox<Rect> over object field in GlyphRun #10879
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Swaps an
object
field withStrongBox<Rect>
when caching ink bounds to allow for faster unboxing when required and increase type-safety in the codebase. Given that caching is present on most codepaths, this could theoretically be better nowadays to embed theRect
directly intoGlyphRun
, but that requires more measurements.In StrongBox, we just load the field:
With object, we have to go through type-check etc:
With 1 box, 100 returns, this gets down to:
Customer Impact
Increased performance, increased type safety and cleaner code.
Regression
No.
Testing
Local build.
Risk
Low.
Microsoft Reviewers: Open in CodeFlow