Remove non-CLS exceptions handlers in PtsHost (dead code) #10875
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes non-CLS exceptions handlers (general catch handler blocks) in
PtsHost
that are never executed (basically a dead-code). This originates from pre-NetFXv2
/C# 2.0
behaviour before non-CLS exceptions were being wrapped by default asRuntimeWrappedException
which derives fromException
and hence you needed a generalcatch
handler.Nowadays Roslyn emits
[assembly: RuntimeCompatibility(WrapNonExceptionThrows = true)]
by default so all non-CLS exceptions are already handled viacatch (Exception e)
blocks and never fallthrough to the generalcatch { }
handler.Customer Impact
Smaller assembly size, codegen size and cleaner codebase for developers.
Regression
No.
Testing
Local build.
Risk
Low, those would be generally caught by CS1058 but the warning was suppressed. Reviewers just need to make sure the removed blocks are preceeded by
catch (Exception e)
to achieve the same effect.Microsoft Reviewers: Open in CodeFlow