Remove non-CLS exceptions handlers in PtsHost (dead code)

[h3xds1nz]

Description

Removes non-CLS exceptions handlers (general catch handler blocks) in PtsHost that are never executed (basically a dead-code). This originates from pre-NetFXv2 / C# 2.0 behaviour before non-CLS exceptions were being wrapped by default as RuntimeWrappedException which derives from Exception and hence you needed a general catch handler.

Nowadays Roslyn emits [assembly: RuntimeCompatibility(WrapNonExceptionThrows = true)] by default so all non-CLS exceptions are already handled via catch (Exception e) blocks and never fallthrough to the general catch { } handler.

Customer Impact

Smaller assembly size, codegen size and cleaner codebase for developers.

Regression

No.

Testing

Local build.

Risk

Low, those would be generally caught by CS1058 but the warning was suppressed. Reviewers just need to make sure the removed blocks are preceeded by catch (Exception e) to achieve the same effect.

Microsoft Reviewers: Open in CodeFlow

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 2.99068%. Comparing base (57fe8ac) to head (d04a2fc).
Report is 10 commits behind head on main.

Additional details and impacted files

@@                 Coverage Diff                 @@
##                main     #10875          +/-   ##
===================================================
- Coverage   13.48885%   2.99068%   -10.49817%     
===================================================
  Files           3317       3319           +2     
  Lines         664749     664330         -419     
  Branches       74643      74675          +32     
===================================================
- Hits           89667      19868       -69799     
- Misses        572488     644281       +71793     
+ Partials        2594        181        -2413     

Flag	Coverage Δ
Debug	2.99068% <ø> (-10.49818%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.