-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Remove dead code in BamlRecordReader associated with TreeBuilderBamlTranslator #10636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
h3xds1nz
wants to merge
12
commits into
dotnet:main
Choose a base branch
from
h3xds1nz:record-reader-methods
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10636 +/- ##
===================================================
+ Coverage 11.22814% 11.23407% +0.00592%
===================================================
Files 3352 3352
Lines 668000 667790 -210
Branches 74980 74955 -25
===================================================
+ Hits 75004 75020 +16
+ Misses 591745 591608 -137
+ Partials 1251 1162 -89
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Community Contribution
A label for all community Contributions
PR
metadata: Label to tag PRs, to facilitate with triage
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes unused/dead code that's just a remnant from
TreeBuilderBamlTranslator
which was only in use forNetFX 3.5
, it is unused sinceNetFX 4.0
and therefore can be safely removed. There's a bit more but this one I'm confident with.Customer Impact
Cleaner codebase for developers, less memory usage.
Regression
No.
Testing
Local build.
Risk
Reviewers should check the correctness of removing/adjusting the if statements after removal of the properties/fields based on their default values.
Microsoft Reviewers: Open in CodeFlow