Remove TreeBuilder and all the dead code associated from PBT #10635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
requested review from
dipeshmsft,
singhashish-wpf and
Kuldeep-MS
dotnet-policy-service
bot
added
PR
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10635 +/- ##
===================================================
- Coverage 11.22814% 11.07186% -0.15629%
===================================================
Files 3352 3352
Lines 668000 668000
Branches 74980 74980
===================================================
- Hits 75004 73960 -1044
- Misses 591745 592881 +1136
+ Partials 1251 1159 -92
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes
TreeBuilder, which is just nowadays an unusedabstractclass from PBT and the associated dead code.This was only in
NetFX 3.5, it is unused sinceNetFX 4.0.Customer Impact
Cleaner codebase for developers.
Regression
No.
Testing
Local build.
Risk
None, unused dead code.
Microsoft Reviewers: Open in CodeFlow