[Managed DWrite] Migrate FontFileEnumerator to managed#10523
Open
ThomasGoulet73 wants to merge 1 commit intodotnet:mainfrom
Open
[Managed DWrite] Migrate FontFileEnumerator to managed#10523ThomasGoulet73 wants to merge 1 commit intodotnet:mainfrom
ThomasGoulet73 wants to merge 1 commit intodotnet:mainfrom
Conversation
dotnet-policy-service
bot
requested review from
Kuldeep-MS,
dipeshmsft and
singhashish-wpf
dotnet-policy-service
bot
added
PR
Contributor
Author
|
@JeremyKuhne: Would you be interested in reviewing this ? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10523 +/- ##
===================================================
- Coverage 11.11073% 10.94044% -0.17029%
===================================================
Files 3215 3216 +1
Lines 648472 648502 +30
Branches 71534 71535 +1
===================================================
- Hits 72050 70949 -1101
- Misses 575427 576559 +1132
+ Partials 995 994 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
JeremyKuhne
approved these changes
Feb 28, 2025
Member
JeremyKuhne
left a comment
JeremyKuhne
left a comment
There was a problem hiding this comment.
The transliteration looks good.
h3xds1nz
reviewed
Mar 6, 2025
...crosoft.DotNet.Wpf/src/PresentationCore/MS/internal/Text/TextInterface/FontFileEnumerator.cs
Show resolved
Hide resolved
|
@JeremyKuhne Any news on this? Would be great to see it upstream. 😊 |
Member
|
Waiting for long time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #5305
Description
Migrate DWrite FontFileEnumerator to managed.
Customer Impact
It might be faster and should allow better support of trimming and the support of NativeAOT once everything is migrated to C#.
Regression
No.
Testing
Local build + CI + I tested a few apps that uses custom fonts to test this code path.
Risk
Low. For the most part, it is a copy of the C++ code manually rewritten to C# with as little changes as possible.
Microsoft Reviewers: Open in CodeFlow