Make sure the Label Edit in ListView has correct position in accessibility tree #9782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonZhao888
changed the title
Epica3055
requested changes
Aug 25, 2023
src/System.Windows.Forms/src/System/Windows/Forms/ListViewLabelEditAccessibleObject.cs
Outdated
Show resolved
Hide resolved
ghost
added
the
waiting-author-feedback
|
Is it possible to write UnitTest? |
ghost
removed
the
waiting-author-feedback
The relevant test cases have been modified. |
src/System.Windows.Forms/src/System/Windows/Forms/ListViewLabelEditAccessibleObject.cs
Outdated
Show resolved
Hide resolved
Tanya-Solyanik
added
the
waiting-author-feedback
ghost
removed
the
waiting-author-feedback
|
@Epica3055 - please re-review and unblock the merge if all your comments are addressed |
Epica3055
approved these changes
Aug 30, 2023
halgab
pushed a commit
to halgab/winforms
that referenced
this pull request
Aug 30, 2023
…ility tree (dotnet#9782) * Adjusting the position of the LabelEdit in the accessibility tree * Update codes * Update code style and test cases * Add back the property of FragmentRoot * Update code style --------- Co-authored-by: Simon Zhao (Beyondsoft Corporation) (from Dev Box) <v-weidzh@microsoft.com>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7263
Proposed changes
Customer Impact
Regression?
Risk
Screenshots
Before
Label Edit is at the same level as the List item and is displayed under the root node of the List.
After
Label Edit displays under the edited cell.
Test methodology
Accessibility testing
Test environment(s)
Microsoft Reviewers: Open in CodeFlow