Enable nullability and refactor LocalizationCodeDomSerializer to replace Hashtable with HashSet
#8675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Set and enable nullability
dreddy-work
reviewed
Feb 23, 2023
...Forms.Design/src/System/ComponentModel/Design/Serialization/LocalizationCodeDomSerializer.cs
Show resolved
Hide resolved
dreddy-work
reviewed
Feb 23, 2023
...Forms.Design/src/System/ComponentModel/Design/Serialization/LocalizationCodeDomSerializer.cs
Outdated
Show resolved
Hide resolved
dreddy-work
reviewed
Feb 23, 2023
...Forms.Design/src/System/ComponentModel/Design/Serialization/LocalizationCodeDomSerializer.cs
Outdated
Show resolved
Hide resolved
dreddy-work
added
the
📭 waiting-author-feedback
|
@elachlan, Didn't you get compile warnings for those missed nullable checks? |
ghost
removed
the
📭 waiting-author-feedback
No, they are not null annotated functions. So no warning. |
|
@dreddy-work I think richnav just timed out, hence the failure. |
dreddy-work
approved these changes
Feb 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #8143, #8357
Microsoft Reviewers: Open in CodeFlow