Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor SelectionManager to replace Hashtable with Dictionary #8664

Merged
merged 2 commits into from
Feb 22, 2023

Conversation

elachlan
Copy link
Contributor

@elachlan elachlan commented Feb 19, 2023

Related: #8143, #8357

Microsoft Reviewers: Open in CodeFlow

@elachlan elachlan requested a review from a team as a code owner February 19, 2023 04:28
@ghost ghost assigned elachlan Feb 19, 2023
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit on the comments that were already there, otherwise LGTM

@lonitra lonitra added the 📭 waiting-author-feedback The team requires more information from the author label Feb 21, 2023
@ghost ghost removed the 📭 waiting-author-feedback The team requires more information from the author label Feb 21, 2023
@lonitra lonitra merged commit bba30b5 into dotnet:main Feb 22, 2023
@ghost ghost added this to the 8.0 Preview2 milestone Feb 22, 2023
@elachlan elachlan deleted the SelectionManager-Hashtable branch February 22, 2023 20:18
@ghost ghost locked as resolved and limited conversation to collaborators Mar 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants