Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor BindingContext to use Dictionary<TKey, TValue> instead of Hashtable and List<T> instead of ArrayList #8235

Merged
merged 25 commits into from
Jan 5, 2023
Merged
Show file tree
Hide file tree
Changes from 19 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
3cd1a42
Refactor BindingContext to use Dictionary<TKey, TValue> instead of H…
Jericho Nov 19, 2022
ed9da11
Iterate DictionaryEntry rather than KeyValuePair in order to avoid br…
Jericho Nov 29, 2022
b80fa24
Fix CS8600 "Converting null literal or possible null value to non-nul…
Jericho Dec 6, 2022
ecc308f
Fix CS8600 "Converting null literal or possible null value to non-nul…
Jericho Dec 7, 2022
099fd05
IDE0057 Substring can be simplified
Jericho Dec 7, 2022
7dc404d
Cast to IDictionary to get an enumerator that works in DictionaryEntry
Jericho Dec 9, 2022
8856f3d
Cast to IDictionary to get DictionaryEntry
Jericho Dec 9, 2022
0f18fbb
Update src/System.Windows.Forms/src/System/Windows/Forms/BindingConte…
Jericho Dec 10, 2022
015ee4e
Fix suggested code
Jericho Dec 10, 2022
99a00d4
Add CollectionHelper.HashTableCopyTo
Jericho Dec 10, 2022
8237b95
Fix failing unit tests
Jericho Dec 10, 2022
d7714c0
Unit tests for the new HashTableCopyTo extension method
Jericho Dec 11, 2022
f68b4bd
Remove unnecessary `using` statement
Jericho Dec 11, 2022
9793a08
Fix typo
Jericho Dec 14, 2022
fc89cfc
Add license
Jericho Dec 14, 2022
58e8f4a
Avoid locals
Jericho Dec 14, 2022
8107ac9
Change declarations
Jericho Dec 14, 2022
3605e45
param names for readability
Jericho Dec 14, 2022
7bcce4c
Use pattern matching
Jericho Dec 14, 2022
fb3b736
Update src/System.Windows.Forms/tests/UnitTests/misc/CollectionHelper…
Jericho Dec 14, 2022
72974af
Update src/System.Windows.Forms/tests/UnitTests/misc/CollectionHelper…
Jericho Dec 14, 2022
68ad45f
Update src/System.Windows.Forms/tests/UnitTests/misc/CollectionHelper…
Jericho Dec 14, 2022
07aabb7
Update src/System.Windows.Forms/src/System/Windows/Forms/BindingConte…
Jericho Dec 14, 2022
569ca07
Revert "Update src/System.Windows.Forms/tests/UnitTests/misc/Collecti…
Jericho Dec 15, 2022
db061d1
Remove redundant unit test
Jericho Dec 15, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/System.Windows.Forms/src/Resources/SR.resx
Original file line number Diff line number Diff line change
Expand Up @@ -6943,4 +6943,19 @@ Stack trace where the illegal operation occurred was:
<data name="AccessDenied" xml:space="preserve">
<value>Access denied</value>
</data>
<data name="ArgumentOutOfRange_NeedNonNegNum" xml:space="preserve">
<value>Non-negative number required.</value>
</data>
<data name="Argument_IncompatibleArrayType" xml:space="preserve">
<value>Target array type is not compatible with the type of items in the collection.</value>
</data>
<data name="Arg_ArrayPlusOffTooSmall" xml:space="preserve">
<value>Destination array is not long enough to copy all the items in the collection. Check array index and length.</value>
</data>
<data name="Arg_NonZeroLowerBound" xml:space="preserve">
<value>The lower bound of target array must be zero.</value>
</data>
<data name="Arg_RankMultiDimNotSupported" xml:space="preserve">
<value>Only single dimensional arrays are supported for the requested action.</value>
</data>
</root>
25 changes: 25 additions & 0 deletions src/System.Windows.Forms/src/Resources/xlf/SR.cs.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

25 changes: 25 additions & 0 deletions src/System.Windows.Forms/src/Resources/xlf/SR.de.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

25 changes: 25 additions & 0 deletions src/System.Windows.Forms/src/Resources/xlf/SR.es.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

25 changes: 25 additions & 0 deletions src/System.Windows.Forms/src/Resources/xlf/SR.fr.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

25 changes: 25 additions & 0 deletions src/System.Windows.Forms/src/Resources/xlf/SR.it.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

25 changes: 25 additions & 0 deletions src/System.Windows.Forms/src/Resources/xlf/SR.ja.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

25 changes: 25 additions & 0 deletions src/System.Windows.Forms/src/Resources/xlf/SR.ko.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

25 changes: 25 additions & 0 deletions src/System.Windows.Forms/src/Resources/xlf/SR.pl.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

25 changes: 25 additions & 0 deletions src/System.Windows.Forms/src/Resources/xlf/SR.pt-BR.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

25 changes: 25 additions & 0 deletions src/System.Windows.Forms/src/Resources/xlf/SR.ru.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading