Moving common logic of keyboard's simulation into the helper class. #7537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikitaSemenovAkvelon
requested review from
Tanya-Solyanik,
RussKie and
vladimir-krestov
|
Moving to .NET8 because this is a refactoring and does not meet the bar for .net7 |
Tanya-Solyanik
added
waiting-author-feedback
NikitaSemenovAkvelon
force-pushed
the
Issue_7506-Refactoring_KeyboardHelper
branch
from
d4f85a9 to
ebb65a8
Compare
ghost
removed
the
waiting-author-feedback
NikitaSemenovAkvelon
force-pushed
the
Issue_7506-Refactoring_KeyboardHelper
branch
from
ebb65a8 to
246e199
Compare
Tanya-Solyanik
previously approved these changes
Aug 8, 2022
vladimir-krestov
previously approved these changes
Aug 8, 2022
| // https://docs.microsoft.com/windows/win32/inputdev/wm-keyup | ||
| // The MSDN page tells us what bits of lParam to use for each of the parameters. | ||
| // All we need to do is some bit shifting to assemble lParam | ||
| // lParam = repeatCount | (scanCode << 16) |
There was a problem hiding this comment.
nit: this is different with the code below. So, I would just remove this line. We see lParam below.
src/System.Windows.Forms/tests/TestUtilities/KeyboardSimulator.cs
Outdated
Show resolved
Hide resolved
Tanya-Solyanik
added
the
waiting-author-feedback
NikitaSemenovAkvelon
dismissed stale reviews from vladimir-krestov and Tanya-Solyanik
via
0b23ab7
NikitaSemenovAkvelon
force-pushed
the
Issue_7506-Refactoring_KeyboardHelper
branch
from
246e199 to
0b23ab7
Compare
ghost
removed
the
waiting-author-feedback
Tanya-Solyanik
previously approved these changes
Aug 9, 2022
vladimir-krestov
previously approved these changes
Aug 9, 2022
|
Please rebase to the latest main to resolve build errors |
…to the helper class.
NikitaSemenovAkvelon
dismissed stale reviews from vladimir-krestov and Tanya-Solyanik
via
a63940c
NikitaSemenovAkvelon
force-pushed
the
Issue_7506-Refactoring_KeyboardHelper
branch
from
0b23ab7 to
a63940c
Compare
@vladimir-krestov - you should be able to re-run build by adding a |
Tanya-Solyanik
approved these changes
Aug 9, 2022
vladimir-krestov
approved these changes
Aug 9, 2022
|
@Tanya-Solyanik this change only affects the test infra, is there any reason not to have this merged? |
good point |
Tanya-Solyanik
removed
the
🚫 * NO-MERGE *
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7506
Proposed changes
Customer Impact
Regression?
Risk
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow