-
Notifications
You must be signed in to change notification settings - Fork 1k
Adding Form subtype in templates #3527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2. Added sources in template.json to remove *.user from "exclude" 3. Fixed a typo in readme.md
Codecov Report
@@ Coverage Diff @@
## master #3527 +/- ##
====================================================
+ Coverage 66.95215% 98.48672% +31.53457%
====================================================
Files 1338 452 -886
Lines 504989 252829 -252160
Branches 40861 4167 -36694
====================================================
- Hits 338101 249003 -89098
+ Misses 161324 3108 -158216
+ Partials 5564 718 -4846
|
Codecov Report
@@ Coverage Diff @@
## master #3527 +/- ##
====================================================
+ Coverage 66.95215% 98.49463% +31.54247%
====================================================
Files 1338 452 -886
Lines 504989 252829 -252160
Branches 40861 4167 -36694
====================================================
- Hits 338101 249023 -89078
+ Misses 161324 3092 -158232
+ Partials 5564 714 -4850
|
Non blocking question, could we have used the |
It doesn't work that way. With |
Thank you |
@merriemcgaw Should we consider this change for 3.1 servicing ? |
Have we verified how this impacts the load time in the designer If this is a noticeable, measurable amount then definitely service! |
In order to load the designer, user needs to either double click on the Form icon or open it through Shift + F7. Both these options are not available to the user for several seconds (>10 sec) after creating a new project. Sometimes the icon just doesn't appear at all. During this time user is completely blocked to load the designer. |
Fixes #3510
To override it, I have added sources in template.json to remove *.user from "exclude"
Verified that:
Microsoft Reviewers: Open in CodeFlow