Update templates to net5.0 #3344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3344 +/- ##
====================================================
+ Coverage 64.68177% 98.68251% +34.00073%
====================================================
Files 1318 430 -888
Lines 484206 230439 -253767
Branches 39910 3142 -36768
====================================================
- Hits 313193 227403 -85790
+ Misses 165638 2401 -163237
+ Partials 5375 635 -4740
|
genalt
approved these changes
May 25, 2020
|
Thank you @ViktorHofer does the same need to happen to https://github.com/dotnet/windowsdesktop? (e.g. https://github.com/dotnet/windowsdesktop/blob/50165b432e03a57e5fafa3e0f3341c201e0fb912/pkg/windowsdesktop/pkg/Microsoft.WindowsDesktop.App.pkgproj#L10) |
10 tasks
|
It shouldn't be strictly necessary for the branding change. I submitted dotnet/windowsdesktop#800 anyway to clean up the remaining mentions of netcoreapp as a tfm. |
ViktorHofer
added a commit
to ViktorHofer/winforms
that referenced
this pull request
May 26, 2020
mmitche
pushed a commit
that referenced
this pull request
May 26, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDK related issue dotnet/sdk#11706
Microsoft Reviewers: Open in CodeFlow