Fix incorrect logic in CharIsPrintable for UnicodeCategory exclusions #14079
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical logic error in the CharIsPrintable method where operator precedence caused incorrect Unicode character classification. The bug resulted in characters from categories like Format, LineSeparator, ParagraphSeparator, and OtherNotAssigned being incorrectly classified as printable.
Key Changes
- Fixed operator precedence by adding parentheses around the
orpattern combination in theCharIsPrintablemethod
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14079 +/- ##
===================================================
- Coverage 77.15510% 77.15293% -0.00218%
===================================================
Files 3279 3279
Lines 645317 645317
Branches 47718 47719 +1
===================================================
- Hits 497895 497881 -14
- Misses 143733 143744 +11
- Partials 3689 3692 +3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14072
Proposed changes
CharIsPrintablecontains a semantic error in the combination of is not and or. As a result, it returns true for any character that is notControl, incorrectly classifying characters fromFormat,LineSeparator,ParagraphSeparator, andOtherNotAssignedas printable.Impact: Zero-width spaces, line separators, paragraph separators, and unassigned code points are treated as printable, even though they render as invisible, garbled symbols, or empty spaces.
Microsoft Reviewers: Open in CodeFlow