Skip to content

Conversation

LeafShi1
Copy link
Member

@LeafShi1 LeafShi1 commented Jun 19, 2025

Related #13288

Proposed changes

  • Add InvokeAsync before executing listView.RectangleToScreen(listView.Items[0].SubItems[1].Bounds)
Microsoft Reviewers: Open in CodeFlow

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR ensures the UI is updated before calculating and moving the mouse to the second column of the first item in a ListView, and adds a guard to fail early if that subitem doesn’t exist.

  • Calls form.InvokeAsync(() => listView.Update()) to process pending UI updates.
  • Adds a runtime check for Items.Count and SubItems.Count before computing listViewCenter, throwing if the subitem is missing.

Copy link

codecov bot commented Jun 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.60625%. Comparing base (08485db) to head (38c1f9f).
Report is 6 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #13626         +/-   ##
===================================================
- Coverage   76.60828%   76.60625%   -0.00203%     
===================================================
  Files           3253        3253                 
  Lines         640996      640996                 
  Branches       47439       47439                 
===================================================
- Hits          491056      491043         -13     
- Misses        146290      146294          +4     
- Partials        3650        3659          +9     
Flag Coverage Δ
Debug 76.60625% <ø> (-0.00203%) ⬇️
integration 18.97990% <ø> (-0.01394%) ⬇️
production 51.06448% <ø> (-0.00452%) ⬇️
test 97.41175% <ø> (ø)
unit 48.44898% <ø> (+0.00208%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All LGTM

@LeafShi1 LeafShi1 merged commit ee675d3 into dotnet:main Jun 24, 2025
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants