Skip to content

Fix leak in UpDownBaseTests #13597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Jun 14, 2025

Fixes #13596

Proposed changes

  • Call OnHandleDestroyed to unsubscribe from UserPreferenceChanged event and fix memory leak in tests.

Customer Impact

  • None. Test only change.

Regression?

  • No

Risk

  • None. Test only change.

Screenshots

Before

After

Test methodology

Accessibility testing

Test environment(s)

Copy link

codecov bot commented Jun 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.60399%. Comparing base (34128e7) to head (802819b).
Report is 49 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #13597         +/-   ##
===================================================
- Coverage   76.61783%   76.60399%   -0.01385%     
===================================================
  Files           3236        3253         +17     
  Lines         639376      641011       +1635     
  Branches       47313       47442        +129     
===================================================
+ Hits          489876      491040       +1164     
- Misses        145973      146313        +340     
- Partials        3527        3658        +131     
Flag Coverage Δ
Debug 76.60399% <100.00000%> (-0.01385%) ⬇️
integration 18.98652% <ø> (+0.44123%) ⬆️
production 51.05822% <ø> (+0.03112%) ⬆️
test 97.41186% <100.00000%> (-0.00097%) ⬇️
unit 48.43821% <ø> (+0.02139%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

LeafShi1
LeafShi1 previously approved these changes Jun 19, 2025
Copy link
Member

@LeafShi1 LeafShi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a little suggestion.

@Youssef1313
Copy link
Member Author

@LeafShi1 Is this good to merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UpDownBaseTests are severely leaking
2 participants