-
Notifications
You must be signed in to change notification settings - Fork 1k
Fix leak in UpDownBaseTests #13597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix leak in UpDownBaseTests #13597
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13597 +/- ##
===================================================
- Coverage 76.61783% 76.60399% -0.01385%
===================================================
Files 3236 3253 +17
Lines 639376 641011 +1635
Branches 47313 47442 +129
===================================================
+ Hits 489876 491040 +1164
- Misses 145973 146313 +340
- Partials 3527 3658 +131
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
src/test/unit/System.Windows.Forms/System/Windows/Forms/UpDownBaseTests.cs
Outdated
Show resolved
Hide resolved
src/test/unit/System.Windows.Forms/System/Windows/Forms/UpDownBaseTests.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a little suggestion.
src/test/unit/System.Windows.Forms/System/Windows/Forms/UpDownBaseTests.cs
Outdated
Show resolved
Hide resolved
src/test/unit/System.Windows.Forms/System/Windows/Forms/UpDownBaseTests.cs
Outdated
Show resolved
Hide resolved
@LeafShi1 Is this good to merge? |
Fixes #13596
Proposed changes
Customer Impact
Regression?
Risk
Screenshots
Before
After
Test methodology
Accessibility testing
Test environment(s)