Skip to content

Add code coverage for DataGridViewImageColumn #13547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Zheng-Li01
Copy link
Member

@Zheng-Li01 Zheng-Li01 commented Jun 3, 2025

Related #13442

Proposed changes

Add unit test file:DataGridViewImageColumnTests.cs for public methods of the DataGridViewImageColumn.cs

Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented Jun 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.63702%. Comparing base (5821493) to head (4fa6e28).
Report is 107 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                  @@
##                main      #13547          +/-   ##
====================================================
+ Coverage   62.21083%   76.63702%   +14.42619%     
====================================================
  Files           3213        3254          +41     
  Lines         638302      641181        +2879     
  Branches       47201       47455         +254     
====================================================
+ Hits          397093      491382       +94289     
+ Misses        234153      146147       -88006     
+ Partials        7056        3652        -3404     
Flag Coverage Δ
Debug 76.63702% <100.00000%> (+14.42619%) ⬆️
integration 18.98721% <ø> (+0.19843%) ⬆️
production 51.11800% <ø> (+32.32922%) ⬆️
test 97.41310% <100.00000%> (+0.00898%) ⬆️
unit 48.50076% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Zheng-Li01 Zheng-Li01 added the waiting-review This item is waiting on review by one or more members of team label Jun 3, 2025
@ricardobossan ricardobossan requested a review from Copilot June 4, 2025 22:31
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds comprehensive unit tests for the DataGridViewImageColumn class, covering its public properties and methods to improve code coverage.

  • Introduces tests for property getters/setters: Description, Icon, Image, ImageLayout, ValuesAreIcons
  • Adds tests for Clone() behavior and ToString() formatting
  • Verifies propagation of property changes to cell templates and existing rows

@dotnet-policy-service dotnet-policy-service bot added the waiting-author-feedback The team requires more information from the author label Jun 4, 2025
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Jun 6, 2025
ricardobossan
ricardobossan previously approved these changes Jun 10, 2025
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@LeafShi1 LeafShi1 removed the waiting-review This item is waiting on review by one or more members of team label Jun 16, 2025
@LeafShi1 LeafShi1 added the waiting-author-feedback The team requires more information from the author label Jun 17, 2025
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Jun 17, 2025
ricardobossan
ricardobossan previously approved these changes Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants