fix #13071 Changing properties with RefreshProperties.All does not requery the property list in the PropertyGrid in .net 9 (worked in .net 8)

[Epica3055]

Fixes #13071

Proposed changes

• revert PR#12431 , use another approach to fix Issue#12440
• Introduce EditMouseDown flag in PropertyGridView.flag. This flag is on when the TextBox in the PropertyGrid.GridEntry is focused and is off when editing is done.
• The cause of Issue#12440 is that after editing is done, GridEntryAccessibleObject will raise AutomationFocusChangedEvent

GridEntry.GridEntryAccessibleObject.cs

        ...
        internal override void SetFocus()
        {
            if (PropertyGridView is null || !PropertyGridView.IsHandleCreated)
            {
                return;
            }

            base.SetFocus();

            RaiseAutomationEvent(UIA_EVENT_ID.UIA_AutomationFocusChangedEventId);
        }

So in order to not let TextBox loose rectangle, add conditions to that event to exclude two cases:

1. when InPropertySet is on
2. when EditMouseDown is on

Regression?

• Yes

Screenshots

Before

GetProperties method didn't get invoked described in #13071

After

Issues13071.01.mp4

Issues13071.02.mp4

Test methodology

• manually

Test environment(s)

10.0.0-preview.3.25165.3

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.56834%. Comparing base (88c3a11) to head (ccd78fc).
Report is 150 commits behind head on main.

Additional details and impacted files

@@                 Coverage Diff                 @@
##                main      #13295         +/-   ##
===================================================
+ Coverage   61.34314%   62.56834%   +1.22520%     
===================================================
  Files           1547        1560         +13     
  Lines         158479      159675       +1196     
  Branches       14751       14904        +153     
===================================================
+ Hits           97216       99906       +2690     
+ Misses         60561       59000       -1561     
- Partials         702         769         +67     

Flag	Coverage Δ
Debug	62.56834% <ø> (-12.60374%)	⬇️
integration	11.31915% <ø> (-7.55283%)	⬇️
production	40.74551% <ø> (-34.42657%)	⬇️
test	95.69057% <ø> (∅)
unit	38.14619% <ø> (-36.11083%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[LeafShi1]

LGTM！Adding a new Flag is indeed a good idea.

[Tanya-Solyanik]

@Epica3055 - is it possible to add unit test? Please send to @Olina-Zhang's team for testing

[Olina-Zhang]

Tested this PR change, GH issues: 13071, 12440, 12421 were fixed. Also tested some properties values list to choose in expand/collapse state using Accessibility Tools: Inspect/AccessibilityInsight/Narrator/NVDA, no new issue found.

[Tanya-Solyanik]

Thank you, nice fix! Please backport it to 9!

[Epica3055]

/backport to release/9.0

[github-actions]

Started backporting to release/9.0: https://github.com/dotnet/winforms/actions/runs/14612889585

[github-actions]

@Epica3055 backporting to release/9.0 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: fix #13071 Changing properties with RefreshProperties.All does not requery the property list in the PropertyGrid in .net 9 (worked in .net 8) : revert PR#12431 , use another approach.
Using index info to reconstruct a base tree...
A	src/System.Windows.Forms/System/Windows/Forms/Controls/PropertyGrid/PropertyGridInternal/GridEntry.GridEntryAccessibleObject.cs
A	src/System.Windows.Forms/System/Windows/Forms/Controls/PropertyGrid/PropertyGridInternal/PropertyGridView.Flags.cs
A	src/System.Windows.Forms/System/Windows/Forms/Controls/PropertyGrid/PropertyGridInternal/PropertyGridView.cs
Falling back to patching base and 3-way merge...
Auto-merging src/System.Windows.Forms/src/System/Windows/Forms/Controls/PropertyGrid/PropertyGridInternal/PropertyGridView.cs
CONFLICT (content): Merge conflict in src/System.Windows.Forms/src/System/Windows/Forms/Controls/PropertyGrid/PropertyGridInternal/PropertyGridView.cs
Auto-merging src/System.Windows.Forms/src/System/Windows/Forms/Controls/PropertyGrid/PropertyGridInternal/GridEntry.GridEntryAccessibleObject.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 fix #13071 Changing properties with RefreshProperties.All does not requery the property list in the PropertyGrid in .net 9 (worked in .net 8) : revert PR#12431 , use another approach.
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!