Don't unwrap wrapped DataObject inner data store (#12800) #12806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating a DataObject from another DataObject we need to keep the original DataObject as the "inner" data so that virtuals get called as they historically have. Also pass through to correct overload on TryGetDataCore. Fixes dotnet#12789
JeremyKuhne
added
the
servicing-consider
Tanya-Solyanik
approved these changes
Jan 18, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/9.0 #12806 +/- ##
=====================================================
+ Coverage 74.83554% 74.83608% +0.00054%
=====================================================
Files 3022 3022
Lines 630413 630478 +65
Branches 46798 46800 +2
=====================================================
+ Hits 471773 471825 +52
- Misses 155258 155266 +8
- Partials 3382 3387 +5
Flags with carried forward coverage won't be shown. Click here to find out more. |
Tanya-Solyanik
added
the
🚫 * NO-MERGE *
JeremyKuhne
added
servicing-approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports #12800, do NOT squash
When creating a DataObject from another DataObject we need to keep the original DataObject as the "inner" data so that virtuals get called as they historically have.
Fixes #12789
Microsoft Reviewers: Open in CodeFlow