Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the Control.DragDrop tests under ControlTests.Methods.cs to Collection "Sequential" #12657

Merged
merged 4 commits into from
Dec 23, 2024
Merged

Move the Control.DragDrop tests under ControlTests.Methods.cs to Collection "Sequential" #12657

merged 4 commits into from
Dec 23, 2024

Conversation

LeafShi1
Copy link
Member

@LeafShi1 LeafShi1 commented Dec 19, 2024 •
edited by dotnet-policy-service bot
Loading

Proposed changes

  • Move the Control.DragDrop tests under ControlTests.Methods.cs to Collection "Sequential"
Microsoft Reviewers: Open in CodeFlow

@dotnet-policy-service dotnet-policy-service bot added the draft draft PR label Dec 19, 2024
@LeafShi1 LeafShi1 marked this pull request as ready for review December 20, 2024 03:54
@LeafShi1 LeafShi1 requested a review from a team as a code owner December 20, 2024 03:54
@dotnet-policy-service dotnet-policy-service bot removed the draft draft PR label Dec 20, 2024
@LeafShi1 LeafShi1 added the waiting-review This item is waiting on review by one or more members of team label Dec 20, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.

Project coverage is 76.03254%. Comparing base (8d96e56) to head (7c4e577).
Report is 7 commits behind head on main.

Additional details and impacted files 
@@                 Coverage Diff                 @@
##                main      #12657         +/-   ##
===================================================
+ Coverage   76.02394%   76.03254%   +0.00860%     
===================================================
  Files           3180        3181          +1     
  Lines         639659      639659                 
  Branches       47216       47216                 
===================================================
+ Hits          486294      486349         +55     
+ Misses        149851      149785         -66     
- Partials        3514        3525         +11
Flag Coverage Δ
Debug 76.03254% <0.00000%> (+0.00860%) ⬆️
integration 18.15655% <ø> (+0.00070%) ⬆️
production 49.82444% <ø> (+0.01441%) ⬆️
test 97.02906% <0.00000%> (+0.00394%) ⬆️
unit 47.05028% <ø> (+0.01089%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

ricardobossan
ricardobossan reviewed Dec 20, 2024
View reviewed changes
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All LGTM

@Tanya-Solyanik Tanya-Solyanik removed the waiting-review This item is waiting on review by one or more members of team label Dec 20, 2024
@LeafShi1 LeafShi1 merged commit 0d813fa into dotnet:main Dec 23, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardobossan ricardobossan ricardobossan left review comments

@Tanya-Solyanik Tanya-Solyanik Tanya-Solyanik approved these changes

Assignees

@LeafShi1 LeafShi1

Labels
None yet
Projects
None yet
Milestone
10.0 Preview1
Development

Successfully merging this pull request may close these issues.
3 participants
@LeafShi1 @Tanya-Solyanik @ricardobossan