Changes DataGridViewCellStyle's SelectionBackColor to custom color, t… #10176
+8
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o enhace contrast for accessibility reasons
src/System.Windows.Forms/src/System/Windows/Forms/DataGridView.cs
Outdated
Show resolved
Hide resolved
Tanya-Solyanik
added
the
waiting-author-feedback
added 3 commits
October 26, 2023 21:29
…9916_DataGridViewFocusLowContrast
…9916_DataGridViewFocusLowContrast
ghost
removed
the
waiting-author-feedback
|
@ricardobossan - something went wrong with git merges, this PR does not show any changed files. Hope you hadn't lost yout changes locally! |
Tanya-Solyanik
added
the
waiting-author-feedback
added 3 commits
October 30, 2023 05:31
…9916_DataGridViewFocusLowContrast
…9916_DataGridViewFocusLowContrast
ghost
removed
the
waiting-author-feedback
LeafShi1
reviewed
Nov 1, 2023
src/System.Windows.Forms/src/System/Windows/Forms/DataGridViewCheckBoxCell.cs
Show resolved
Hide resolved
added 2 commits
November 3, 2023 17:53
…gh contrast themes
…9916_DataGridViewFocusLowContrast
LeafShi1
approved these changes
Nov 7, 2023
|
/backport to release/8.0 |
|
Started backporting to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9916
Proposed changes
DefaultDefaultCellStyleproperty of theSystem.Windows.Forms.DataGridViewclass, to use a color forSelectionBackColorthat allows better contrast ratio between the background and focus indicator of the selected cell.Customer Impact
Regression?
Risk
Screenshots
Before
Contrast between background and focus indicator:
Contrast between background and text:
After
Contrast between background and focus indicator:
Contrast between background and text:
Test methodology
Accessibility testing
Test environment(s)
Microsoft Reviewers: Open in CodeFlow