Add Label Edit to TreeView #10149
Merged
Add Label Edit to TreeView #10149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonZhao888
requested review from
Tanya-Solyanik,
lonitra,
LeafShi1 and
Epica3055
|
The failure test cases are not related to this PR. |
Epica3055
reviewed
Oct 20, 2023
src/System.Windows.Forms/src/System/Windows/Forms/LabelEditAccessibleObject.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/LabelEditNativeWindow.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/LabelEditNativeWindow.cs
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/ListViewLabelEditAccessibleObject.cs
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
lonitra
reviewed
Oct 20, 2023
src/System.Windows.Forms/src/System/Windows/Forms/LabelEditAccessibleObject.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/LabelEditUiaTextProvider.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/ListViewLabelEditAccessibleObject.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/ListViewLabelEditAccessibleObject.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/ListViewLabelEditAccessibleObject.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/ListViewLabelEditAccessibleObject.cs
Outdated
Show resolved
Hide resolved
lonitra
added
the
waiting-author-feedback
ghost
removed
the
waiting-author-feedback
lonitra
reviewed
Oct 23, 2023
...Windows.Forms/tests/UnitTests/System/Windows/Forms/TreeViewLabelEditAccessibleObjectTests.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/ListViewLabelEditAccessibleObject.cs
Outdated
Show resolved
Hide resolved
lonitra
added
the
waiting-author-feedback
lonitra
reviewed
Oct 23, 2023
src/System.Windows.Forms/src/System/Windows/Forms/ListViewLabelEditAccessibleObject.cs
Outdated
Show resolved
Hide resolved
ghost
removed
the
waiting-author-feedback
lonitra
added
the
waiting-author-feedback
ghost
removed
the
waiting-author-feedback
lonitra
added
the
ready-to-merge
ghost
removed
the
ready-to-merge
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9956
Proposed changes
Customer Impact
Regression?
Risk
Screenshots
Before
The LabelEdit control of TreeViewNode will be placed as a first child of the TreeView in accessibility tree.
After
The LabelEdit control of TreeViewNode will place as a child of the Editing TreeNode in accessibility tree.
Test methodology
Accessibility testing
Test environment(s)
Microsoft Reviewers: Open in CodeFlow
Microsoft Reviewers: Open in CodeFlow