Skip to content

[release/8.0] Update dependencies from dotnet/arcade #10101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 20, 2023
Merged

[release/8.0] Update dependencies from dotnet/arcade #10101

merged 10 commits into from
Oct 20, 2023

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Oct 12, 2023 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: bcf5aa31-6777-442e-8e36-08db9e435944
  • Build: 20231016.4
  • Date Produced: October 16, 2023 7:28:01 PM UTC
  • Commit: 39042b4048580366d35a7c1c4f4ce8fc0dbea4b4
  • Branch: refs/heads/release/8.0
Microsoft Reviewers: Open in CodeFlow

@dotnet-maestro dotnet-maestro bot requested a review from a team as a code owner October 12, 2023 12:49
ghost
ghost previously approved these changes Oct 12, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go, you big red fire engine!

@lonitra
Copy link
Member

lonitra commented Oct 12, 2023

Error:
.dotnet\sdk\8.0.100-rc.1.23455.8\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(90,5): error NETSDK1211: (NETCORE_ENGINEERING_TELEMETRY=Restore) EnableSingleFileAnalyzer is not supported for the target framework. Consider multi-targeting to a supported framework to enable single-file analysis, and set EnableSingleFileAnalyzer only for the supported frameworks. For example:
true

@lonitra
Copy link
Member

lonitra commented Oct 13, 2023

dotnet/sdk#35851 seems to be the PR that addresses these errors. Perhaps it has not flowed through yet

@dreddy-work
Copy link
Member

dreddy-work commented Oct 18, 2023 •
edited
Loading

@mmitche , any idea on this failure? Or should we need RC2?

dotnet-maestro bot and others added 8 commits October 20, 2023 14:17
@dotnet-maestro @lonitra
Update dependencies from https://github.com/dotnet/arcade build 20231…
f759d59 
…005.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.CMake.Sdk , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.23463.1 -> To Version 8.0.0-beta.23505.1
@dotnet-maestro @lonitra
Update dependencies from https://github.com/dotnet/arcade build 20231…
e829389 
…005.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.CMake.Sdk , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.23463.1 -> To Version 8.0.0-beta.23505.1
@dotnet-maestro @lonitra
Update dependencies from https://github.com/dotnet/arcade build 20231…
4a31e68 
…005.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.CMake.Sdk , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.23463.1 -> To Version 8.0.0-beta.23505.1
@dotnet-maestro @lonitra
Update dependencies from https://github.com/dotnet/arcade build 20231…
7ee5ee8 
…005.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.CMake.Sdk , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.23463.1 -> To Version 8.0.0-beta.23505.1
@dotnet-maestro @lonitra
Update dependencies from https://github.com/dotnet/arcade build 20231…
08548c9 
…005.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.CMake.Sdk , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.23463.1 -> To Version 8.0.0-beta.23505.1
@dotnet-maestro @lonitra
Update dependencies from https://github.com/dotnet/arcade build 20231…
5996c50 
…005.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.CMake.Sdk , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.23463.1 -> To Version 8.0.0-beta.23505.1
@dotnet-maestro @lonitra
Update dependencies from https://github.com/dotnet/arcade build 20231…
6452dd3 
…016.4

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.CMake.Sdk , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.23463.1 -> To Version 8.0.0-beta.23516.4
@lonitra
Disable EnableSingleFileAnalyzer and related for .NET Framework and .…
b107187 
…NET Standard projects
@lonitra lonitra force-pushed the darc-release/8.0-8c10e2ef-7fd3-4b24-8811-637bc40f102a branch from 238ebef to b107187 Compare October 20, 2023 22:44
@lonitra
Copy link
Member

lonitra commented Oct 20, 2023

Per https://review.learn.microsoft.com/en-us/dotnet/core/compatibility/sdk/8.0/trimming-unsupported-targetframework?branch=main, changed EnableSingleFileAnalyzer and EnableTrimAnalyzer to be disabled for .NET Standard and .NET Framework projects.

Additionally upgraded Cswin32 to include fix for PInvoke006 error (microsoft/CsWin32#1037) and suppressed IDE0090 errors about simplifying to new() when constructing objects.

@lonitra lonitra enabled auto-merge (squash) October 20, 2023 23:23
@lonitra lonitra merged commit 40fd54e into release/8.0 Oct 20, 2023
@lonitra lonitra deleted the darc-release/8.0-8c10e2ef-7fd3-4b24-8811-637bc40f102a branch October 20, 2023 23:42
@ghost ghost locked as resolved and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mmitche mmitche mmitche approved these changes

+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lonitra @dreddy-work @mmitche