Dark Mode: The ForeColor & BackColor properties are not working for the controls

[Zheng-Li01]

.NET version

.NET SDK 10.0.100-rc.1.25414.103

Did it work in .NET Framework?

No

Did it work in any of the earlier releases of .NET Core or .NET 5+?

Yes, The issue reproduce on .NET SDK 10.0.100-preview.6.25358.103 build, not reproduce on .NET SDK 10.0.100-preview.5.25277.114

Issue description

The ForeColor & BackColor properties are not working for the controls:
The ForeColor is not working for Button control
The BackColor is not working for Button, TextBox, DomainUpDown, NumericUpDown, RichTextBox, MaskedTextBox contorls

.NET SDK 10.0.100-preview.6.25358.103

.NET SDK 10.0.100-preview.5.25277.114

Steps to reproduce

1. Open the attached application
   ReproApplication.zip
2. Build & run the project
3. Observe the results

[Epica3055]

@KlausLoeffelmann

2 PRs contributed to this issue. 13582 broke OwnerDraw logic. 6b489724 broke the color choosing logic.

Is this your intended design?

if not, I can help fix it.

[KlausLoeffelmann]

It is intended...until it isn't.

Here is the thing:
When it comes to the Button, we are already in a quite inconsistent state for applying colors with Visual Styles and some of the Button styles (at least System), if I remember correctly.

I need to do a bit more of research for this.
Ultimately, I want to get rid of using the System Renderer, because that thing definitely does not color correctly. (Let alone render images of any kind.)

For the TextBox-based scenarios, I am a bit surprised.
Enabled should work, although I know we got some issues around VisualStyles in classic mode as well, and the question is, how consistent we want to be, since we're definitely not changing light mode behavior.

@Epica3055: If you know how to address this, could you try to get behind it more and maybe even prepare a fix, so we would be able to take it on short notice, should we decide to take it?

And as a separate ask:
Could you or @LeafShi1 - in a separate PR - also take a look at the White-Label-issue for dark mode?

Thanks so much!

Klaus

[LeafShi1]

@KlausLoeffelmann Regarding White-Label-issue, are you referring to this issue? #13779, I added a comment under this issue, please check it out and help confirm.