Remove new Microsoft.NETCore.App.Ref targeting pack assemblies from WindowsDesktop targeting pack #1747
Conversation
…indowsDesktop's targeting pack
ryalanms
changed the title
|
Unblocks #1746. |
|
@dreddy-work we'll need to scan our codebase for these as well. |
|
Thanks, @RussKie. |
| @@ -36,7 +36,7 @@ | |||
| manually enabled by updating the metadata. | |||
| --> | |||
| <ItemGroup> | |||
| <ProjectServicingConfiguration Include="Microsoft.WindowsDesktop.App.Ref" PatchVersion="0" /> | |||
| <ProjectServicingConfiguration Include="Microsoft.WindowsDesktop.App.Ref" PatchVersion="6.0.0" /> | |||
There was a problem hiding this comment.
This is wrong. PatchVersion should not be the full version but just the last digit. AFAIK this setting is only relevant during servicing. @jkoritzinsky and @dagood should know more about it.
There was a problem hiding this comment.
Looks like including ("major.minor.patch".) in the comment above this group might be confusing. Intended it to just be an example of where patch version is in a full version number, but easy to interpret differently. Probably clearer just to remove it and let the rest of the comment clarify that it should normally be the same as PatchVersion.
|
You are missing some of the changes that I did in the preview 6 PR: #1742. More precisely, the Version.Detail.xml and the Versions.props changes. |
|
Thanks, everyone. #1753. |
Required by:
Remove new Microsoft.NETCore.App.Ref targeting pack assemblies from WindowsDesktop targeting packs, and update versions.props to rebuild WindowsDesktop targeting packs.