Skip to content

Profile Classification Should Come from Repo that Produces DLL #4796

Open
@lonitra

Description

In windowsdesktop we have profiling for dlls in the ref and runtime pack
Currently the profile specification for dlls in the ref/runtime pack is disconnected from the repos that actually produce them, which can easily lead to mis profiling the dlls.
In WinForms, we have https://github.com/dotnet/winforms/blob/main/pkg/Microsoft.Private.Winforms/sdk/dotnet-windowsdesktop/System.Windows.Forms.FileClassification.props which profiles all winforms dlls for the ref pack and windowsdesktop simply pulls this in via https://github.com/dotnet/windowsdesktop/blob/main/src/windowsdesktop/src/sfx/Microsoft.WindowsDesktop.App.Ref.sfxproj#L25. We should set up a similar system for WPF and for the runtime pack to help with the disconnect and avoid mis profiling dlls.

Note that when it comes to the runtime pack, analyzers should not be included #4227 (comment)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions