Skip to content

Some of profile attribute on files in windows desktop runtime pack are wrong #4708

Open

Description

Description

Some of the files tagged as WinForms and WPF in #4227 are wrong, these are all WPF specific and are not used by WinForms:

<FrameworkListFileClass Include="System.Xaml.resources.dll" Profile="WindowsForms;WPF" />
<FrameworkListFileClass Include="UIAutomationClient.resources.dll" Profile="WindowsForms;WPF" />
<FrameworkListFileClass Include="UIAutomationClientSideProviders.resources.dll" Profile="WindowsForms;WPF" />
<FrameworkListFileClass Include="UIAutomationProvider.resources.dll" Profile="WindowsForms;WPF" />
<FrameworkListFileClass Include="UIAutomationTypes.resources.dll" Profile="WindowsForms;WPF" />
<FrameworkListFileClass Include="WindowsBase.resources.dll" Profile="WindowsForms;WPF" />
<FrameworkListFileClass Include="WindowsFormsIntegration.resources.dll" Profile="WindowsForms;WPF" />
<FrameworkListFileClass Include="PenImc_cor3.dll" Profile="WindowsForms;WPF" />
<FrameworkListFileClass Include="vcruntime140_cor3.dll" Profile="WindowsForms;WPF" />
<FrameworkListFileClass Include="wpfgfx_cor3.dll" Profile="WindowsForms;WPF" />
<FrameworkListFileClass Condition="'$(PlatformTarget)' != 'ARM64'" Include="D3DCompiler_47_cor3.dll" Profile="WindowsForms;WPF" />

The .resources.dll files in this bloc are tagged as WPF and WinForms when the regular dll is tagged as WPF only. Which means that in the publish you get the .resources.dll file without the matching .dll file.

For WindowsFormsIntegration.resources.dll it's unclear because the regular dll file is tagged as WPF and WinForms when AFAIK it shouldn't be used when it's WinForms only:

<FrameworkListFileClass Include="WindowsFormsIntegration.dll" Profile="WindowsForms;WPF"/>

If I do the steps to reproduce in the issue dotnet/sdk#37088, I get those files in the output when they shouldn't be used at runtime.

/cc @LakshanF since you were the one to add the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions